Sounds good to me.
I guess we never really asked why we should or should not set it and
initially just did it because it looked cool :)
Regards
Carsten
Am 15.07.2020 um 12:54 schrieb Konrad Windszus:
Given the lack of response I would like to propose to no longer define
service.vendor in our bundles. IMHO just unnecessary overhead.
Please raise you voice if you don't agree
Thanks,
Konrad
On 7. Jul 2020, at 15:46, Konrad Windszus <[email protected]> wrote:
Hi,
I am wondering if we should set the OSGi service property "service.vendor" at all for
our services
(https://docs.osgi.org/specification/osgi.core/7.0.0/framework.service.html#framework.service.serviceproperties
<https://docs.osgi.org/specification/osgi.core/7.0.0/framework.service.html#framework.service.serviceproperties>).
It used to be set with the maven-scr-plugin centrally but with bnd-maven-plugin this
is no longer easily doable:
https://github.com/bndtools/bnd/issues/4217#issuecomment-654822460
<https://github.com/bndtools/bnd/issues/4217#issuecomment-654822460>
Also I am wondering what the benefit is for setting that property at all. I have not
seen it exposed anywhere. IMHO just setting the bundle.vendor
(https://docs.osgi.org/specification/osgi.core/7.0.0/framework.module.html#d0e2049
<https://docs.osgi.org/specification/osgi.core/7.0.0/framework.module.html#d0e2049>)
is totally sufficient (done centrally via parent pom)
WDYT?
Konrad
--
--
Carsten Ziegeler
Adobe Research Switzerland
[email protected]
