cziegeler commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/1#issuecomment-669101239
Thanks for the PR - the current code looks strange, however with the suggest PR a NPE might occur as sudo might be null. The current boolean is taking this into account. I think a much better way would be to remove that boolean and the setCookie check and adjust the following if blocks ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
