Hi Robert, I think I stumbled upon a regression with the changes done to the build of the org-apache-sling-launchpad-testing project. Specifically, if I combine the "eclipse:eclipse" goal with the "install" or "verify" goal in the same mvn command line, it results in an error about a duplicate feature file. This command worked in the past, so maybe you might know what the problem is? It appears that the "aggregate-features" goal is getting called twice during this build scenario and not handling it well.
For example: *org-apache-sling-launchpad-testing $ **mvn clean eclipse:eclipse verify* Results in this error: [ERROR] Failed to execute goal org.apache.sling:slingfeature-maven-plugin:1.3.6:aggregate-features (aggregate-features) on project org.apache.sling.launchpad.testing: Execution aggregate-features of goal org.apache.sling:slingfeature-maven-plugin:1.3.6:aggregate-features failed: More than one feature file for classifier testing-oak_tar in project org.apache.sling:org.apache.sling.launchpad.testing:jar:12-SNAPSHOT : [aggregate testing-oak_tar, aggregate testing-oak_tar] -> [Help 1] A workaround is to run the "eclipse:eclipse" goal and the "install" or "verify goal in separate runs. Regards, -Eric On Wed, Aug 5, 2020 at 10:35 AM Robert Munteanu <[email protected]> wrote: > Hi, > > With the merge of the two PRs for the Sling Starter [1] and Launchpad- > Testing [2] the Sling starter is now switched to the feature model. > > This completes Phase 2, as defined in the migration plan [3]. Please > keep an eye open for regressions, as it "works on my machine and > Jenkins". > > As a reminder, for Phase 3 we do have a number of important but > "boring" tasks defined, like documentation, feature model refinements ( > Dan already spotted a potential improvement in the PR [4]), and it > would be great if others could pick up some of the tasks. > > Thanks, > Robert > > [1]: https://github.com/apache/sling-org-apache-sling-starter/pull/11 > [2]: > https://github.com/apache/sling-org-apache-sling-launchpad-testing/pull/2 > [3]: > https://cwiki.apache.org/confluence/display/SLING/Migrating+the+Sling+Starter+to+the+Feature+Model > [4]: > https://github.com/apache/sling-org-apache-sling-starter/pull/11#pullrequestreview-461877061 > >
