[
https://issues.apache.org/jira/browse/SLING-9648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173899#comment-17173899
]
Konrad Windszus commented on SLING-9648:
----------------------------------------
IMHO exposing sling.properties even in a feature launcher makes sense, why
would you only be interested in that with the launchpad?
The exception in the activate was the easiest way to prevent this service from
starting in case the property is not set. Starting it without this property
doesn’t make much sense as the you cannot expose anything.
So two questions here:
1. Why does the web console plugin not make sense for feature launcher?
2. How to make the service conditional on the property with a declarative
approach without relying on exceptions?
> SlingPropertiesPrinter fails to activate: No bundle context property
> 'sling.properties.url' provided
> ----------------------------------------------------------------------------------------------------
>
> Key: SLING-9648
> URL: https://issues.apache.org/jira/browse/SLING-9648
> Project: Sling
> Issue Type: Bug
> Reporter: Robert Munteanu
> Priority: Major
> Fix For: Settings 1.4.2
>
>
> When starting up the Sling Starter I see the following error printed on the
> console:
> {noformat}ERROR: bundle org.apache.sling.settings:1.4.0
> (22)[org.apache.sling.settings.impl.SlingPropertiesPrinter(1)] : Error
> during instantiation of the implementation object
> java.lang.reflect.InvocationTargetException
> at
> java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
> at
> org.apache.felix.scr.impl.inject.internal.ComponentConstructorImpl.newInstance(ComponentConstructorImpl.java:312)
> at
> org.apache.felix.scr.impl.manager.SingleComponentManager.createImplementationObject(SingleComponentManager.java:279)
> at
> org.apache.felix.scr.impl.manager.SingleComponentManager.createComponent(SingleComponentManager.java:115)
> at
> org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:984)
> at
> org.apache.felix.scr.impl.manager.SingleComponentManager.getServiceInternal(SingleComponentManager.java:957)
> at
> org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:902)
> at
> org.apache.felix.framework.ServiceRegistrationImpl.getFactoryUnchecked(ServiceRegistrationImpl.java:348)
> at
> org.apache.felix.framework.ServiceRegistrationImpl.getService(ServiceRegistrationImpl.java:248)
> at
> org.apache.felix.framework.ServiceRegistry.getService(ServiceRegistry.java:350)
> at org.apache.felix.framework.Felix.getService(Felix.java:3954)
> at
> org.apache.felix.framework.BundleContextImpl.getService(BundleContextImpl.java:450)
> at
> org.apache.felix.inventory.impl.webconsole.WebConsoleAdapter.addingService(WebConsoleAdapter.java:152)
> at
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
> at
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:871)
> at
> org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
> at
> org.osgi.util.tracker.AbstractTracked.trackInitial(AbstractTracked.java:183)
> at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:321)
> at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:264)
> at
> org.apache.felix.inventory.impl.webconsole.WebConsoleAdapter.<init>(WebConsoleAdapter.java:68)
> at org.apache.felix.inventory.impl.Activator.start(Activator.java:63)
> at
> org.apache.felix.framework.util.SecureAction.startActivator(SecureAction.java:698)
> at org.apache.felix.framework.Felix.activateBundle(Felix.java:2402)
> at org.apache.felix.framework.Felix.startBundle(Felix.java:2308)
> at org.apache.felix.framework.Felix.setActiveStartLevel(Felix.java:1539)
> at
> org.apache.felix.framework.FrameworkStartLevelImpl.run(FrameworkStartLevelImpl.java:308)
> at java.base/java.lang.Thread.run(Thread.java:834)
> Caused by: java.lang.IllegalStateException: No bundle context property
> 'sling.properties.url' provided
> at
> org.apache.sling.settings.impl.SlingPropertiesPrinter.<init>(SlingPropertiesPrinter.java:64)
> ... 30 more
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
