stefan-egli commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-discovery-support/pull/1#issuecomment-672073971
Thx @mreutegg for the review, I've applied all findings, incl > Did you consider using Sling Metrics instead of introducing a dependency to dropwizard directly? yea, I agree, it's nicer to depend on sling.commons.metrics, done that now [here](https://github.com/apache/sling-org-apache-sling-discovery-support/pull/1/commits/ae26769f02134aabedada3dcfe5dbf3ed5e64132) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
