ghenzler commented on a change in pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/5#discussion_r491888031
##########
File path:
src/test/java/org/apache/sling/auth/core/impl/SlingAuthenticatorTest.java
##########
@@ -373,19 +373,16 @@ public void test_emptyNodeAuthenticationHandlerPath()
throws Throwable {
/**
* Mocks the request to accept method calls on path;
*
- * @param request http request
- * @param requestPath path in the http request
- * @param authProtectedPath path protected by the auth handler
+ * @param request http request
+ * @param requestPath request path
*/
- private void buildExpectationsForRequestPathAndAuthPath(final
HttpServletRequest request,
- final String requestPath,
- final String authProtectedPath) {
+ private void buildExpectationsForRequest(final HttpServletRequest request,
+ final String requestPath) {
{
Mockito.when(request.getServletPath()).thenReturn(requestPath);
Mockito.when(request.getServerName()).thenReturn("localhost");
Mockito.when(request.getServerPort()).thenReturn(80);
Mockito.when(request.getScheme()).thenReturn("http");
- Mockito.when(request.getAttribute("path")).thenReturn(requestPath);
Review comment:
@cziegeler just stumbled upon this when the changes for the resource
mapping SPI - this is not needed anymore (and I gave the method a better name
for the status quo)
##########
File path:
src/test/java/org/apache/sling/auth/core/impl/SlingAuthenticatorTest.java
##########
@@ -373,19 +373,16 @@ public void test_emptyNodeAuthenticationHandlerPath()
throws Throwable {
/**
* Mocks the request to accept method calls on path;
*
- * @param request http request
- * @param requestPath path in the http request
- * @param authProtectedPath path protected by the auth handler
+ * @param request http request
+ * @param requestPath request path
*/
- private void buildExpectationsForRequestPathAndAuthPath(final
HttpServletRequest request,
- final String requestPath,
- final String authProtectedPath) {
+ private void buildExpectationsForRequest(final HttpServletRequest request,
+ final String requestPath) {
{
Mockito.when(request.getServletPath()).thenReturn(requestPath);
Mockito.when(request.getServerName()).thenReturn("localhost");
Mockito.when(request.getServerPort()).thenReturn(80);
Mockito.when(request.getScheme()).thenReturn("http");
- Mockito.when(request.getAttribute("path")).thenReturn(requestPath);
Review comment:
@cziegeler just stumbled upon this when starting the changes for the
resource mapping SPI - this is not needed anymore (and I gave the method a
better name for the status quo)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
