Hi all,
so "SlingUri" (with now improved name) as prerequisite for
the Mapping SPI has now been fixed via SLING-9745 and is on
master. This alone is just a utility - no behaviour of
resolve() or map() has been changed (yet).
With the changes [1] [2] [3] [4] (only on branches so far)
the URI mapping is moved before authentication - this will
improve the situation for auth requirements as Carsten
outlined in [5]. I have tested this in both Sling Starter
and the famous Sling-based CMS and it works well.
For now the updated proposal keeps out context hints (like
e.g. "link invalid") for simplicity, we can can add this
later (if we wanted to allow for link checking to get rid
of the need for the rewriter pipeline that takes this
responsibility in a Sling-based CMS)
I think it'll good to discuss this at the round table next
Monday, however it would be great if people could already
provide feedback to the API changes in [1] to see if that
makes sense for everyone.
-Georg
[1] Sling API Changes
https://github.com/apache/sling-org-apache-sling-api/compare/master...feature/SLING-9662-Introduce-SlingUri-Mapping-SPI-v3
[2] Auth Core
https://github.com/apache/sling-org-apache-sling-auth-core/compare/master...feature/SLING-9662-Introduce-SlingUri-Mapping-SPI-v3
[3] Engine
https://github.com/apache/sling-org-apache-sling-engine/compare/master...feature/SLING-9662-Introduce-SlingUri-Mapping-SPI-v3
[4] Resource Resolver
https://github.com/apache/sling-org-apache-sling-resourceresolver/compare/master...feature/SLING-9662-Introduce-SlingUri-Mapping-SPI-v3
[5]
https://issues.apache.org/jira/browse/SLING-9622?focusedCommentId=17182336&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17182336
On 2020-09-20 21:46, Georg Henzler wrote:
Considering that URIs like 'mailto:j...@example.com', '?name=val'
or '#fragment' do not relate to a resource and thinking about it
a bit more, I would now propose to change the name of
ResourceUri/ResourceUriBuilder to SlingUri/SlingUriBuilder
(see also [1]) - objections?
-Georg
[1]
https://github.com/apache/sling-org-apache-sling-api/pull/23#discussion_r491726353
On 2020-09-18 11:14, Georg Henzler wrote:
Hi all,
to not have too many changes in one issue and PR to review,
I created SLING-9745 and PR [1] for the ResourceUri and
its builder. The unit test coverage is good (~85%) and also
covers the tests from SlingRequestPathInfoTest [2] to
ensure compatibility. Timely feedback would be appreciated
as I would like to build upon this on Mon (with the next PR).
-Georg
[1]
https://github.com/apache/sling-org-apache-sling-api/pull/23
[2]
https://github.com/apache/sling-org-apache-sling-engine/blob/43673bddb4a2e79ef9bba813ec86a7faa89e7649/src/test/java/org/apache/sling/engine/impl/request/SlingRequestPathInfoTest.java#L28
