Robert / Team, Any thoughts / concerns? I would like to get this fix in place.
On Thu, Oct 22, 2020 at 2:34 PM Daniel Klco <[email protected]> wrote: > Robert, > > I agree it could be misconfigured, however the intent is to only configure > it when needed and for the code to work the same as the current > functionality if not configured. > > The challenge I see with requiring the implementer to support separating > their content into two bundles is that it pushes the complexity of the > internal functionality of the repository onto the implementing team rather > than handling it inside the application. We know that /apps and /libs > shouldn't be written to at runtime, so why require the user to consider > this? Especially when the side-effect is that the entire bundle content > fails to install. > > I'm very much willing to look into other options, but I'm not a huge fan > of having users refactor their codebase to support internal implementation > details, especially when it's only required for certain setups. > > On Thu, Oct 22, 2020 at 10:12 AM Robert Munteanu <[email protected]> > wrote: > >> On Wed, 2020-10-21 at 08:25 -0400, Daniel Klco wrote: >> > Seeding Setting: >> > - Includes Path: [ "^/apps/.*", "^/libs/.*", "^/oak:index/.*" ] >> > >> > Runtime Setting: >> > - Includes Path: [ "^/.*" ] >> > - Excludes Path: [ "^/apps/.*", "^/libs/.*", "^/oak:index/.*" ] >> > >> > The Bundle Content Loader would then filter out the path roots based >> > on the >> > include / exclude rules. I would only expect this to happen at the >> > path >> > root, not for the individual nodes being loaded. The configuration >> > would >> > not be required and in that case the Bundle Content Loader would load >> > all >> > content. >> >> I think this will work. I am wondering though whether we are not >> opening the door for surprising behaviours and misconfigurations. I >> think the only scenario where this is useful is: >> >> - bundle A is used in a composite node store setup >> - bundle A contains resources that belong to both the default mounnt >> and the non-default one ( /libs, /apps ) >> - bundle A installs content using the content loader >> >> I think that a better solution would be to avoid this problem >> altogether by separating 'code' bundles from 'content' bundles, and >> only installing the 'code' bundle when seeding. >> >> Thanks, >> Robert >> >>
