> > [OK] Verified signatures > [OK] Verified checksums > Thanks for confirming these manually! The smoke test actually does this as well.
[BAD] Makefile missing license header > Fair. > [BAD] helm-carts/index.yaml missing licence header > [BAD] most yaml files in source tarball are missing license headers > These are auto-generated. So we can add the header after the generation, but the generators don't allow for specifying a header unfortunately. [UNKNOWN] what is helm-charts/solr-operator-0.3.0.tgz.prov? This provenance file is how helm charts are "signed". It's generated when creating the chart and asking for it to be signed with a GPG key. When the provenance file exists, you can use the "--verify" flag when installing a chart: helm install --verify solr-operator apache/solr-operator [UNKNOWN] why are we releasing zookeeperclusters.yaml with our crds? > This is for user convenience, and allows for one location to download the necessary CRDs for a version. It is also because the Zookeeper Operator does not handle CRDs well, therefore we disable CRD creation by default. Because of this by default the user has to install the Zookeeper CRD manually, thus including it with our CRDs sounded like a much better user experience. It's not really a fork, just a copy of their release CRD for the version of the Zookeeper Operator we support. - Houston On Thu, Apr 15, 2021 at 5:03 PM Mike Drob <[email protected]> wrote: > -1 > > [OK] Verified signatures > [OK] Verified checksums > > [BAD] helm-carts/index.yaml missing licence header > [BAD] most yaml files in source tarball are missing license headers > [BAD] Makefile missing license header > > [UNKNOWN] what is helm-charts/solr-operator-0.3.0.tgz.prov? It looks > like a gpg signed yaml file, maybe this is part of the helm standard > but the filename looks confusing to me. > [UNKNOWN] why are we releasing zookeeperclusters.yaml with our crds? > It's not our code, I don't want us to be forking it. Do we have to > include it?' > > Will continue testing and reviewing, but those were the first things that > I saw. > > On Thu, Apr 15, 2021 at 4:20 PM Houston Putman <[email protected]> wrote: > > > > Updated the release wizard, but not my draft email.... > > > > You need to clone the solr-operator repository and checkout the > release-0.3 branch before running the smoke test. > > And you should run the smoke test from the base directory of the > solr-operator repo. > > > > Hope it goes smoothly for everyone! > > > > - Houston > > > > On Thu, Apr 15, 2021 at 3:53 PM Houston Putman <[email protected]> > wrote: > >> > >> Please vote for release candidate 1 for the Solr Operator v0.3.0 > >> > >> The artifacts can be downloaded from: > >> > https://dist.apache.org/repos/dist/dev/solr/solr-operator/solr-operator-v0.3.0-RC1-rev8b14ce2567599561358eaa7d75210cd29fd21a41 > >> > >> You can run the full smoke tester, with instructions below. > >> However, it is also encouraged to go and use the artifacts yourself in > a test Kubernetes cluster. > >> The smoke tester does not require you to download or install the RC > artifacts before running. > >> If you plan on just running the smoke tests, then ignore all other > instructions. > >> > >> The artifacts are layed out in the following way: > >> * solr-operator-v0.3.0.tgz - Contains the source release > >> * crds/ - Contains the CRD files > >> * helm/ - Contains the Helm release packages > >> > >> The RC Docker image can be found at: > >> apache/solr-operator:v0.3.0-rc1 > >> > >> The RC Helm repo can be added with: > >> helm repo add solr-operator-rc > https://dist.apache.org/repos/dist/dev/solr/solr-operator/solr-operator-v0.3.0-RC1-rev8b14ce2567599561358eaa7d75210cd29fd21a41/helm-charts > >> > >> You can install the RC Solr Operator and CRDs with: > >> kubectl create -f > https://dist.apache.org/repos/dist/dev/solr/solr-operator/solr-operator-v0.3.0-RC1-rev8b14ce2567599561358eaa7d75210cd29fd21a41/crds/all-with-dependencies.yaml > >> helm install --verify solr-operator solr-operator-rc/solr-operator > --set image.tag=v0.3.0-rc1 > >> > >> You can run the full smoke tester directly with this command: > >> > >> ./hack/release/smoke_test/smoke_test.sh -v "v0.3.0" -s "8b14ce2" -i > "apache/solr-operator:v0.3.0-rc1" \ > >> -l ' > https://dist.apache.org/repos/dist/dev/solr/solr-operator/solr-operator-v0.3.0-RC1-rev8b14ce2567599561358eaa7d75210cd29fd21a41 > ' > >> > >> Make sure you have the following installed before running the smoke > test: > >> - Docker (Give it enough memory and CPU to run ~12 containers, 3 of > which are Solr nodes) > >> - Go 1.16 > >> - Kubectl > >> - GnuPG > >> - Helm v3.4.0+ > >> - Kustomize (v4.0.0+) This will be installed for you, but NOT > upgraded if a lower version is already installed. > >> - yq > >> - jq > >> > >> The vote will be open for at least 72 hours i.e. until 2021-04-20 21:00 > UTC. > >> (I have extended this to Tuesday, since the vote occurs over a weekend) > >> > >> [ ] +1 approve > >> [ ] +0 no opinion > >> [ ] -1 disapprove (and reason why) > >> > >> Here is my +1 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
