Ok can I mark these tests AwaitsFix with that URL or do you want a separate ticket for fixing this problem?
On Thu, May 13, 2021 at 10:20 AM Andras Salamon <[email protected]> wrote: > We are planning to migrate it to a package: > https://issues.apache.org/jira/browse/SOLR-14660 please do not remove it > before that if it's possible. > > Andras > > On Thu, May 13, 2021 at 3:59 PM Gus Heck <[email protected]> wrote: > >> Given that HdfsDirectory has been deprecated since 8.6 and is now >> breaking, is it time to declare this removed for 9.0? >> >> On Thu, May 13, 2021 at 9:29 AM David Smiley <[email protected]> wrote: >> >>> I believe those tests failed when Lucene changed the Directory APIs from >>> big endian to little endian: >>> * LUCENE-9047 - Directory APIs should be little endian >>> >>> ~ David Smiley >>> Apache Lucene/Solr Search Developer >>> http://www.linkedin.com/in/davidwsmiley >>> >>> >>> On Thu, May 13, 2021 at 5:38 AM Andras Salamon <[email protected]> >>> wrote: >>> >>>> Hi, >>>> >>>> I tested locally with the provided seed the test failed 3 out of 3 >>>> times. >>>> >>>> I reverted SOLR-15329 (that's my commit) and tested again, it also >>>> failed 3 out of 3 times. >>>> >>>> The fail rates for this test there is a small jump between 04-12 and >>>> 04-19 and a large one between 04-26 and 05-03. >>>> >>>> 2021-03-29,0 >>>> 2021-04-05,0 >>>> 2021-04-12,0 >>>> 2021-04-19,0.0149253731343284 >>>> 2021-04-26,0.0175438596491228 >>>> 2021-05-03,0.268852459016393 >>>> 2021-05-10,0.262820512820513 >>>> >>>> This commit was added at 2021-04-22. >>>> >>>> So I think it's not caused by SOLR-15329, but this is really the only >>>> hdfs change here. >>>> >>>> What lucene versions does solr use for the tests? Snaphot? In that case >>>> it might be caused by a lucene change. >>>> >>>> Andras >>>> >>>> >>>> On 2021/05/13 04:04:30, Gus Heck <[email protected]> wrote: >>>> > Does anyone know what is going on with these? The uptick in failures >>>> > < >>>> http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.index.hdfs.CheckHdfsIndexTest.testChecksumsOnly >>>> > >>>> > for several of these tests seems not far removed from the fix for >>>> SOLR-15329 >>>> > <https://issues.apache.org/jira/browse/SOLR-15329> though I have no >>>> real >>>> > logic to tie that change to these failures. The HDFS seem to have >>>> > significant failure rates on >>>> > http://fucit.org/solr-jenkins-reports/failure-report.html and they >>>> are >>>> > failing repeatedly locally for me >>>> > >>>> > In particular this test/seed failed three times in a row on a clean >>>> > checkout for me. >>>> > >>>> > gradlew :solr:core:test --tests >>>> > "org.apache.solr.index.hdfs.CheckHdfsIndexTest.testChecksumsOnly" >>>> > -Ptests.jvms=30 -Ptests.jvmargs=-XX:TieredStopAtLevel=1 >>>> > -Ptests.seed=566ED88C9109BEFC -Ptests.file.encoding=US-ASCII >>>> > >>>> > With no seed setting intellij to repeat it 10 times, with and without >>>> > forking per method it fails 12/20 times so it's unclear if the seed is >>>> > really important the assert seems to boil down to clean != true but >>>> one has >>>> > to have fairly deep knowledge AFAICT to know what that might mean... >>>> > >>>> > java.lang.AssertionError >>>> > at >>>> __randomizedtesting.SeedInfo.seed([6A2064644BC20F78:C8C5AD47A90DF7B8]:0) >>>> > at org.junit.Assert.fail(Assert.java:87) >>>> > at org.junit.Assert.assertTrue(Assert.java:42) >>>> > at org.junit.Assert.assertTrue(Assert.java:53) >>>> > at >>>> > >>>> org.apache.lucene.index.BaseTestCheckIndex.testChecksumsOnly(BaseTestCheckIndex.java:121) >>>> > at >>>> > >>>> org.apache.solr.index.hdfs.CheckHdfsIndexTest.testChecksumsOnly(CheckHdfsIndexTest.java:145) >>>> > at >>>> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native >>>> > Method) >>>> > at >>>> > >>>> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) >>>> > at >>>> > >>>> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>>> > at java.base/java.lang.reflect.Method.invoke(Method.java:566) >>>> > at >>>> > >>>> com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1754) >>>> > at >>>> > >>>> com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:942) >>>> > at >>>> > >>>> com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:978) >>>> > at >>>> > >>>> com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:992) >>>> > at >>>> > >>>> org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsFixedStatement.callStatement(BaseDistributedSearchTestCase.java:1087) >>>> > at >>>> > >>>> org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsStatement.evaluate(BaseDistributedSearchTestCase.java:1058) >>>> > at >>>> > >>>> com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:57) >>>> > at org.junit.rules.RunRules.evaluate(RunRules.java:20) >>>> > at >>>> > >>>> org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:44) >>>> > >>>> > -Gus >>>> > >>>> > -- >>>> > http://www.needhamsoftware.com (work) >>>> > http://www.the111shift.com (play) >>>> > >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [email protected] >>>> For additional commands, e-mail: [email protected] >>>> >>>> >> >> -- >> http://www.needhamsoftware.com (work) >> http://www.the111shift.com (play) >> > -- http://www.needhamsoftware.com (work) http://www.the111shift.com (play)
