I think I was just the reviewer / committer on that SOLR-6370, before Ram was made committer, so I don't have a ton of background on the actual work done. The JIRA gives some details on the intent.
Overall, I agree this is probably not actively used for much other than reporting at the end of tests. I've personally never used it for debugging and would be fine with removing it esp. if it's blocking progress on moving to ZK 3.7.0. I also think our ZK interfacing code is much more solid at this point than what was there in 2014, so maybe watcher abuse is not as much of a concern? Tim On Mon, May 17, 2021 at 11:27 AM Mike Drob <[email protected]> wrote: > > [Resending to the correct list] > > Hi Devs, > > Do folks use the Zookeeper watch limits? What are they useful for > debugging? Can somebody give me an example of when they have been > helpful to you? > > The main reason I am asking is because I am looking at switching our > TestZookeeper to use the new 3.7.0 ZooKeeperServerEmbedded feature and > it would greatly simplify my task if I didn't need to worry about the > watch limits. > > It's believable that they add value, but they also look like the logic > hasn't been touched since 2014 by the mighty Tim Potter. > > Most of the times that I see them come up in the test output, it's > because something else failed anyway and we had lots of other watches > not get cleaned up, and the object release tracker went haywire as > well. > > Maybe Mark has some stuff on reference branch that makes these more > constrained as well? > > Hoping somebody knows the historical context and use case for these! > > Mike > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
