I guess. This is between the test-framework and solr-core... I bet some of these classes access the core's internals via package-scope... Don't know how much effort it takes but split packages are evil and will cause headaches (javadoc is a prime example here as it parses a package list as input for its external links).
Dawid On Thu, Aug 26, 2021 at 3:53 PM Mike Drob <[email protected]> wrote: > > I am very against packages split across multiple jars/modules, so would > imagine that a package move is necessary > > On Thu, Aug 26, 2021 at 8:04 AM Dawid Weiss <[email protected]> wrote: >> >> This fails for me locally: >> :solr:documentation:checkBrokenLinks >> >> and yet github actions passed (they do run the same command). I see >> the following offender: >> >> [root]/solr/main/solr/documentation/build/site/benchmark/org/apache/solr/bench/MiniClusterState.html >> BROKEN LINK: >> [root]/solr/main/solr/documentation/build/site/core/org/apache/solr/cloud/MiniSolrCloudCluster.html >> >> which is indeed a link from the benchmark module... but not to the >> core - it's a link to the test framework's project. >> >> I think the same package split may be to blame here somehow - the >> build will pass or fail depending on the order of projects. I don't >> know how this can be reasonably fixed. >> >> D. >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
