It's been >72h since the vote was initiated and the result is: +1 4 (4 binding) 0 0 -1 0
This vote has PASSED Thanks for the input Mike, we will definitely have the project integrate build tools better in v0.5.0! On Mon, Sep 13, 2021 at 7:58 AM Jason Gerlowski <[email protected]> wrote: > +1 from me. Ran the smoketest and created a few deployments manually > in Kubernetes-desktop > > On Fri, Sep 10, 2021 at 5:24 PM Mike Drob <[email protected]> wrote: > > > > +1, but there's a bunch of problems that I ran into. > > > > ******************** > > Successfully smoke tested the Solr Operator v0.4.0! > > > > Ran into this error because I had go 1.17 installed instead of 1.16: > > > > ./hack/check_format.sh > > These files did not pass the ‘go fmt’ check, please run ‘go fmt’ on them: > > > > diff -u ./api/v1beta1/zz_generated.deepcopy.go.orig > ./api/v1beta1/zz_generated.deepcopy.go > > --- ./api/v1beta1/zz_generated.deepcopy.go.orig 2021-09-10 > 14:58:31.000000000 -0500 > > +++ ./api/v1beta1/zz_generated.deepcopy.go 2021-09-10 14:58:31.000000000 > -0500 > > @@ -1,3 +1,4 @@ > > +//go:build !ignore_autogenerated > > // +build !ignore_autogenerated > > /* > > make: *** [check-format] Error 1 > > > > Then I had to remove controller-gen and reinstall it because the version > I had was still built with 1.17 > > > > Check to make sure the generated code is up to date > > > > diff --recursive api generated-check/api > > > > diff --recursive api/v1beta1/zz_generated.deepcopy.go > generated-check/api/v1beta1/zz_generated.deepcopy.go > > > > 0a1 > > > > > //go:build !ignore_autogenerated > > > > make: *** [check-generated] Error 1 > > > > Then I had a bunch of issues running the tests because what I thought > was enough Docker resources apparently wasn't. Would appreciate next time > explicitly quantifying what "enough CPU and memory" means. > > > > > > > > > > On Thu, Sep 9, 2021 at 1:43 PM Timothy Potter <[email protected]> > wrote: > >> > >> +1 (binding) for the Solr Operator v0.4.0 RC1 > >> > >> I ran the smoke tester + tested locally in Docker Desktop + deployed in > EKS. > >> > >> Looks great, thanks Houston! > >> > >> On Wed, Sep 8, 2021 at 1:00 PM Timothy Potter <[email protected]> > wrote: > >> > > >> > If anyone is interested in testing the Solr operator against the > >> > recently cut Solr 8.10 branch, I just pushed a Docker image (built > >> > locally) to: thelabdude/apache-solr-dev:8.10.0-SNAPSHOT > >> > > >> > SolrCloud CR YAML: > >> > > >> > solrImage: > >> > repository: thelabdude/apache-solr-dev > >> > tag: 8.10.0-SNAPSHOT > >> > > >> > Cheers, > >> > Tim > >> > > >> > On Tue, Sep 7, 2021 at 9:40 AM Houston Putman <[email protected]> > wrote: > >> > > > >> > > Please vote for release candidate 1 for the Solr Operator v0.4.0 > >> > > > >> > > The artifacts can be downloaded from: > >> > > > https://dist.apache.org/repos/dist/dev/solr/solr-operator/solr-operator-v0.4.0-RC1-revfae48c193d24950fa682a72a00e43579c3b8de04 > >> > > > >> > > You can run the full smoke tester, with instructions below. > >> > > However, it is also encouraged to go and use the artifacts yourself > in a test Kubernetes cluster. > >> > > The smoke tester does not require you to download or install the RC > artifacts before running. > >> > > If you plan on just running the smoke tests, then ignore all other > instructions. > >> > > > >> > > The artifacts are layed out in the following way: > >> > > * solr-operator-v0.4.0.tgz - Contains the source release > >> > > * crds/ - Contains the CRD files > >> > > * helm/ - Contains the Helm release packages > >> > > > >> > > The RC Docker image can be found at: > >> > > apache/solr-operator:v0.4.0-rc1 > >> > > > >> > > The RC Helm repo can be added with: > >> > > helm repo add apache-solr-rc > https://dist.apache.org/repos/dist/dev/solr/solr-operator/solr-operator-v0.4.0-RC1-revfae48c193d24950fa682a72a00e43579c3b8de04/helm-charts > >> > > > >> > > You can install the RC Solr Operator and Solr CRDs and an example > Solr Cloud with: > >> > > curl -sL0 "https://dist.apache.org/repos/dist/release/solr/KEYS"; > | gpg --import --quiet > >> > > # This will export your public keys into a format that helm can > understand. > >> > > # Skip verification by removing "--verify" in the helm command > below. > >> > > if ! (gpg --no-default-keyring --keyring=~/.gnupg/pubring.gpg > --list-keys "98F3F6EC"); then gpg --export >~/.gnupg/pubring.gpg; fi > >> > > kubectl create -f > https://dist.apache.org/repos/dist/dev/solr/solr-operator/solr-operator-v0.4.0-RC1-revfae48c193d24950fa682a72a00e43579c3b8de04/crds/all-with-dependencies.yaml > || \ > >> > > kubectl replace -f > https://dist.apache.org/repos/dist/dev/solr/solr-operator/solr-operator-v0.4.0-RC1-revfae48c193d24950fa682a72a00e43579c3b8de04/crds/all-with-dependencies.yaml > >> > > helm install --verify solr-operator apache-solr-rc/solr-operator > --set image.tag=v0.4.0-rc1 > >> > > helm install --verify example apache-solr-rc/solr > >> > > > >> > > You can run the full smoke tester directly with this command: > (First checkout the release-0.4 branch of the solr-operator) > >> > > > >> > > ./hack/release/smoke_test/smoke_test.sh -v "v0.4.0" -s "fae48c1" -i > "apache/solr-operator:v0.4.0-rc1" -g "98F3F6EC" \ > >> > > -l ' > https://dist.apache.org/repos/dist/dev/solr/solr-operator/solr-operator-v0.4.0-RC1-revfae48c193d24950fa682a72a00e43579c3b8de04 > ' > >> > > > >> > > If you want to run the smoke test with a specific version of > kubernetes, use the -k option with a full version tag. (e.g. -k v1.19.3) > >> > > > >> > > Make sure you have the following installed before running the smoke > test: > >> > > - Docker (Give it enough memory and CPU to run ~12 containers, 3 > of which are Solr nodes) > >> > > - Go 1.16 > >> > > - Kubectl > >> > > - GnuPG > >> > > - Helm v3.4.0+ > >> > > - Kustomize (v4.0.0+) This will be installed for you, but NOT > upgraded if a lower version is already installed. > >> > > - yq > >> > > - jq > >> > > - coreutils (if using Mac OS) > >> > > > >> > > The vote will be open for at least 72 hours i.e. until 2021-09-10 > 16:00 UTC. > >> > > > >> > > [ ] +1 approve > >> > > [ ] +0 no opinion > >> > > [ ] -1 disapprove (and reason why) > >> > > > >> > > Here is my +1 > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
