Hi Artem, Thanks for contributing! It sounds like you are doing pretty much the right things, possibly more diligently than most, and are up to the point that can sometimes be a bit frustrating, which is getting the attention of a committer with interest and time to review/submit your code (probably with changes by you or them after review). Alas I am not that committer right now, Although I have some interest, I do not have the spare cycles to add yet another iron to the fire right now, but mailing this list was exactly the right thing to do :). When I first started contributing I had an issue or two that took a couple months to get attention, but that's life since we're all volunteers, and the few that get paid by someone to contribute something are typically paid to contribute a specific thing that their employer or customer wants to see added or improved. Hang in there, and if you haven't got a review within a week or so, pester this list again (no more than weekly though). Regarding unused imports, the coding standard for the project definitely (at least tries to) prohibit them. If they are lurking in the existing code base that's something that needs to be addressed (though not in your patch unless you've touched the class for other reasons). As for speed of tests, if you haven't checked it out yet, you might find interesting information on how to set the number of test JVM's to max out your processor cores in ./gradlew helpTests. There is also a helpIDEs task as well.
-Gus On Thu, Dec 30, 2021 at 3:59 AM Abeleshev Artyom <abeles...@gmail.com> wrote: > Hi, everyone! > > I tried today to make my first contribution to Solr. I was targeting this > issue https://issues.apache.org/jira/browse/SOLR-15842 concerning > collection backup. I read all the contribution guides I found, but still > don't get a clear picture of the process. > > I first made a detailed investigation of the problem and also wrote an > article explaining how the process is organized from the perspective of > code (you can check it here: > https://tyoma.hashnode.dev/code-anatomy-solr-collection-backup). I've > added a description of the root of the problem in the JIRA issue. Then I > used the GitHub way for contributing: create fork of the project, create > feature branch, test it locally, then create pull request. I can see that > my PR is now linked in the issue so it seems to work. > > I'm not sure what the next steps are. Should I duplicate on dev mailing > list some info about the issue or further updates? I know there is an issue > concerning contribution https://issues.apache.org/jira/browse/SOLR-15682 > but it seems that it is still on the way (maybe I can help with this after > I get enough understanding of it by myself) > > Also couple of questions concerning the project build: > > 1. I'm using Eclipse IDE. Before importing the project, I applied gradle's > eclipse task to arrange project structure. It seems that generated eclipse > project properties have applied settings for Unused import to Error. This > leads to the situation that after importing a clean project it will contain > errors in Eclipse due to some classes having unused imports. Maybe we > should clean those classes or set loose an error type to Warning? > > 2. Tests. I tried to follow the contribution recommendations concerning > checks and tests before/after doing changes. But each time I run full tests > it takes about 2-4 hours to finish (yeah, I know my old good pal is not > that strong). But the most disappointing thing for me was that tests almost > always fail for me and... with different sets of errors. I'm still trying > to find the reesons, but if there is good practice on how to improve that > part I will greatly appreciate it. > > Best regards, > Artem Abeleshev > -- http://www.needhamsoftware.com (work) http://www.the111shift.com (play)
