Agree, the official Dockerfile is now part of the VOTE, so this is a valid veto. Well spotted Houston, since it makes no sense to try to use the Dockerfile without build-arg at this stage.
> 29. mar. 2022 kl. 22:27 skrev Houston Putman <[email protected]>: > > Sorry Jan, I must -1 the candidate. > > The official dockerfile is still using the download locations from lucene, > not the Solr TLP. > # These should never be overridden except for the purposes of testing the > Dockerfile before release > ARG > SOLR_CLOSER_URL="http://www.apache.org/dyn/closer.lua?filename=solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz&action=download > > <http://www.apache.org/dyn/closer.lua?filename=solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz&action=download>" > ARG > SOLR_DIST_URL="https://www.apache.org/dist/lucene/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz > > <https://www.apache.org/dist/lucene/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz>" > ARG > SOLR_ARCHIVE_URL="https://archive.apache.org/dist/lucene/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz > > <https://archive.apache.org/dist/lucene/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz>" > > Will have a PR ready soon (with some release wizard changes that satisfy > Ishan's request). > Though we might want to wait a day or two for RC2 in case people can find > other issues. > > - Houston > > On Tue, Mar 29, 2022 at 4:16 PM Houston Putman <[email protected] > <mailto:[email protected]>> wrote: > We should definitely provide ways to build the image yourself, and in the > future use apache/solr-nightly for release candidates. But for the first > release I don't think it requires another RC. > > Here is the way to build the docker image yourself: > > docker build > https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC1-rev-4ea6ecc35c0f6585c76e0713acfe917ccfe3b8cf/solr/docker/Dockerfile.official > > <https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC1-rev-4ea6ecc35c0f6585c76e0713acfe917ccfe3b8cf/solr/docker/Dockerfile.official> > --build-arg > SOLR_DOWNLOAD_URL=https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC1-rev-4ea6ecc35c0f6585c76e0713acfe917ccfe3b8cf/solr/solr-9.0.0.tgz > > <https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC1-rev-4ea6ecc35c0f6585c76e0713acfe917ccfe3b8cf/solr/solr-9.0.0.tgz> > -t solr-rc:9.0.0-rc1 > > On Tue, Mar 29, 2022 at 3:43 PM Ishan Chattopadhyaya > <[email protected] <mailto:[email protected]>> wrote: > I don't think anyone should attempt to vet this RC1 from that non official > docker image (cominvent). If we want users to test the docker image, let us > host it on docker-solr's hub (or provide steps for user to build for > themselves and try). > > On Tue, 29 Mar, 2022, 11:48 pm Jan Høydahl, <[email protected] > <mailto:[email protected]>> wrote: > Please vote for release candidate 1 for Solr 9.0.0 > > The artifacts can be downloaded from: > https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC1-rev-4ea6ecc35c0f6585c76e0713acfe917ccfe3b8cf > > <https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC1-rev-4ea6ecc35c0f6585c76e0713acfe917ccfe3b8cf> > > You can run the smoke tester directly with this command: > > python3 -u dev-tools/scripts/smokeTestRelease.py \ > https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC1-rev-4ea6ecc35c0f6585c76e0713acfe917ccfe3b8cf > > <https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC1-rev-4ea6ecc35c0f6585c76e0713acfe917ccfe3b8cf> > > NB: Make sure to do a 'git pull' on branch_9_0 to get the latest smoketester > version. > > Since this is a major release I encourage a more thorough manual inspection > and test of the artifacts than the smoke tester alone. > > A Docker image is available at docker hub as "cominvent/solr:9.0.0-rc1" > > The vote will be open for at least 72 hours i.e. until 2022-04-01 19:00 UTC. > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > Here is my +1 > > SUCCESS! [0:51:42.777256] > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > <mailto:[email protected]> > For additional commands, e-mail: [email protected] > <mailto:[email protected]> >
