Hey all,
TL;DR Can contribs/modules only extend Solr "core" classes, or are they a
valid way to package extensions of SolrJ functionality as well?
----
I put in a review recently on a PR for SOLR-15857. [1]. The PR introduces
a new module ('aws-secret-provider') that extends a SolrJ interface to let
Solr fetch ZK creds out of AWS's "Secret Manager" cloud service. [2]. The
PR looks great, but....
AFAICT, aws-secret-provider would be the first module whose main purpose is
to extend SolrJ classes. There's nothing wrong with that per-se, but it
does seem to be an outlier, so I figured I'd check to see if there wasn't
some rule or convention against this, or some other way people would
recommend this sort of functionality to be packaged.
(Other than its connection to SolrJ I think the functionality is a textbook
example of what contribs are supposed to be: it's something that makes
sense to ship but maybe not have on the classpath by default.)
Anyone have any objections or recommendations for other ways this could be
packaged?
Best,
Jason
[1] https://github.com/apache/solr/pull/826
[2] https://aws.amazon.com/secrets-manager/
