I put a PR up that builds on Shawn's work and doesn't need manage process permissions.
Kevin Risden On Sat, Oct 15, 2022, 18:07 Shawn Heisey <apa...@elyograg.org> wrote: > https://issues.apache.org/jira/browse/SOLR-8803 > > In which I change Solr 9.2.0 so it crashes on OOME when using bin/solr > or bin\solr.cmd and creates a crash file that DOES show the resource > which was depleted to cause the OOME. Seen far too often that Solr dies > from OOME and there is no exception logged anywhere. > > The patch looks good to me, and I have tested it on both Linux and > Windows. I'm opening it up for this wide review because it's a little > bit of a fundamental part of Solr to be changing, and I want to make > sure I am not overlooking something. > > I was a little dismayed that I had to give the manageProcess > RuntimePermission to the security manager, just to get Java to let me > have the JVM's PID. I am hoping that what I can get from Java without > adding permissions, or by adding a far more granular permission, is the > full path of the crashfile. Three days ago, I asked > hotspot-gc-...@openjdk.net if that was possible and have gotten no > reply, not even "this mailing list is not the right place for that > question." Because Solr should not be running with administrator > privileges if our recommendations are being followed, manageProcess > might be OK, but others might not like my bikeshed color. > > Thanks, > Shawn > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org > For additional commands, e-mail: dev-h...@solr.apache.org > >
