I think it would be beneficial for SolrClient to be immutable.  Users
cache/pool them (even Solr itself via SolrClientCache) which can lead to
problems if somewhere code mutates them after they've been published.
SolrClients have Builders so we're already on the path to make this happen.

Years ago, Jason created a JIRA issue about this very thing:
https://issues.apache.org/jira/browse/SOLR-8975
but it's rather hard, particularly across so many Solr tests that do
manipulations all over the place.  I like that it's decomposed into
sub-JIRAs.  These could easily be "newdev", by the way.

Eric Pugh (unaware of SOLR-8975) started pulling a thread on this sweater,
and we've been chatting a bit about it.  Anyway, I'm just posting here for
general awareness of the direction we're going in with SolrJ.  Changes to
SolrJ are a high touch-point for our users so better to publicize.

~ David Smiley
Apache Lucene/Solr Search Developer
http://www.linkedin.com/in/davidwsmiley

Reply via email to