Both SOLR-16527 and SOLR-16457 committed to branch_9_1

On Mon, Nov 7, 2022, 21:25 Ishan Chattopadhyaya <ichattopadhy...@gmail.com>
wrote:

> I am doing a bit of performance testing, and things look good again. I'll
> spin RC2 once these are merged.
>
> On Tue, 8 Nov, 2022, 7:54 am Ishan Chattopadhyaya, <
> ichattopadhy...@gmail.com> wrote:
>
> > Sure, please go ahead.
> >
> > On Tue, 8 Nov, 2022, 6:05 am Kevin Risden, <kris...@apache.org> wrote:
> >
> >> I'm going to revert the change from branch_9_1 for
> >> https://issues.apache.org/jira/browse/SOLR-16457 - this was only
> >> introduced
> >> in 9.1.
> >>
> >> Shawn pointed out some issues using the official installer script and
> >> symlinks.
> >>
> >> Kevin Risden
> >>
> >>
> >> On Mon, Nov 7, 2022 at 5:59 PM Jan Høydahl <jan....@cominvent.com>
> wrote:
> >>
> >> > Hi,
> >> >
> >> > Can we add https://issues.apache.org/jira/browse/SOLR-16527 to 9.1
> >> before
> >> > RC2? It fixes a NPE which was introduced in 9.1 and thus not yet
> >> released.
> >> > The PR is simple and soon ready to merge.
> >> >
> >> > Jan
> >> >
> >> > > 4. nov. 2022 kl. 13:55 skrev Christine Poerschke (BLOOMBERG/
> LONDON) <
> >> > cpoersc...@bloomberg.net>:
> >> > >
> >> > > SOLR-16502 backport is complete, including moving of the
> >> > solr/CHANGES.txt entry on branch_9x and main.
> >> > >
> >> > > From: dev@solr.apache.org <mailto:dev@solr.apache.org> At: 11/03/22
> >> > 18:00:09 UTCTo:  dev@solr.apache.org <mailto:dev@solr.apache.org>
> >> > > Subject: Re: [VOTE] Release Solr 9.1.0 RC1
> >> > >
> >> > > Sure Christine and Gus, please proceed with merging.
> >> > >
> >> > > On Thu, 3 Nov, 2022, 8:37 pm Gus Heck, <gus.h...@gmail.com <mailto:
> >> > gus.h...@gmail.com>> wrote:
> >> > >
> >> > >> Also, maybe we can add my ref guide change?
> >> > >> https://issues.apache.org/jira/browse/SOLR-16495
> >> > >>
> >> > >> On Thu, Nov 3, 2022 at 9:57 AM Christine Poerschke (BLOOMBERG/
> >> LONDON) <
> >> > >> cpoersc...@bloomberg.net <mailto:cpoersc...@bloomberg.net>> wrote:
> >> > >>
> >> > >>> If there's a respin I'd love to see
> >> > >>> https://github.com/apache/solr/pull/1141 for
> >> > >>> https://issues.apache.org/jira/browse/SOLR-16502 backported.
> Would
> >> > that
> >> > >>> be okay?
> >> > >>>
> >> > >>> From: dev@solr.apache.org At: 11/03/22 04:26:11 UTCTo:
> >> > >>> dev@solr.apache.org
> >> > >>> Subject: Re: [VOTE] Release Solr 9.1.0 RC1
> >> > >>>
> >> > >>> Noble and I traced the slowdown to the SOLR-16414, we shall commit
> >> the
> >> > >> fix
> >> > >>> shortly.
> >> > >>> The parallelStream use there had a drastic performance issue, and
> >> nodes
> >> > >>> never shut down gracefully (with 1000 cores/node).
> >> > >>> I'd like to -1 this and re-spin, if no one has any objections.
> >> > >>>
> >> > >>> On Thu, Nov 3, 2022 at 4:46 AM Ishan Chattopadhyaya <
> >> > >>> ichattopadhy...@gmail.com> wrote:
> >> > >>>
> >> > >>>> During a performance test run (which I'll make available publicly
> >> > >> soon),
> >> > >>>> we discovered that the RC1's Solr nodes don't stop gracefully
> >> during a
> >> > >>> test
> >> > >>>> that creates thousands of collections across 8 nodes and restarts
> >> them
> >> > >> (2
> >> > >>>> at a time).
> >> > >>>> This is not a -1 yet, since we're trying to figure out which
> commit
> >> > may
> >> > >>>> have caused this. I'll report back on this as soon as I have more
> >> > >>>> information on this.
> >> > >>>>
> >> > >>>> On Mon, Oct 31, 2022 at 10:15 PM Jason Gerlowski <
> >> > >> gerlowsk...@gmail.com>
> >> > >>>> wrote:
> >> > >>>>
> >> > >>>>> SUCCESS! [0:37:11.183352]
> >> > >>>>>
> >> > >>>>> +1
> >> > >>>>>
> >> > >>>>> Did a bit of manual backup/restore testing through the operator
> +
> >> the
> >> > >>>>> smoketester.
> >> > >>>>>
> >> > >>>>> On Mon, Oct 31, 2022 at 6:43 AM Ishan Chattopadhyaya
> >> > >>>>> <ichattopadhy...@gmail.com> wrote:
> >> > >>>>>>
> >> > >>>>>> I'll leave this open for another 3 days, due to Halloween/long
> >> > >> weekend
> >> > >>>>> in
> >> > >>>>>> USA. Please let me know if anyone has any objections/concerns.
> >> > >>>>>>
> >> > >>>>>> On Sat, 29 Oct, 2022, 3:54 am Noble Paul, <
> noble.p...@gmail.com>
> >> > >>> wrote:
> >> > >>>>>>
> >> > >>>>>>> SUCCESS! [1:09:31.684716]
> >> > >>>>>>>
> >> > >>>>>>> +1
> >> > >>>>>>>
> >> > >>>>>>> On Sat, Oct 29, 2022 at 8:07 AM Houston Putman <
> >> > >> hous...@apache.org>
> >> > >>>>> wrote:
> >> > >>>>>>>
> >> > >>>>>>>> SUCCESS! [0:32:29.104358]
> >> > >>>>>>>>
> >> > >>>>>>>> I also ran the smoke test for the solr operator with this
> >> image:
> >> > >>>>>>>>
> >> > >>>>>>>> Successfully smoke tested the Solr Operator v0.6.0!
> >> > >>>>>>>>
> >> > >>>>>>>> +1
> >> > >>>>>>>>
> >> > >>>>>>>> - Houston
> >> > >>>>>>>>
> >> > >>>>>>>> On Fri, Oct 28, 2022 at 12:57 PM Joel Bernstein <
> >> > >>> joels...@gmail.com
> >> > >>>>>>
> >> > >>>>>>>> wrote:
> >> > >>>>>>>>
> >> > >>>>>>>>> +1
> >> > >>>>>>>>>
> >> > >>>>>>>>> SUCCESS! [1:17:27.016191]
> >> > >>>>>>>>>
> >> > >>>>>>>>>
> >> > >>>>>>>>> I kicked the tires on the assets as well. Created a 2 shard
> >> > >>>>> collection,
> >> > >>>>>>>>> loaded data, ran the SQL module, ran streaming expressions.
> >> > >> Saw
> >> > >>> no
> >> > >>>>>>>>> problems.
> >> > >>>>>>>>>
> >> > >>>>>>>>>
> >> > >>>>>>>>> Joel Bernstein
> >> > >>>>>>>>> http://joelsolr.blogspot.com/
> >> > >>>>>>>>>
> >> > >>>>>>>>>
> >> > >>>>>>>>> On Thu, Oct 27, 2022 at 10:14 AM Kevin Risden <
> >> > >>> kris...@apache.org
> >> > >>>>>>
> >> > >>>>>>>> wrote:
> >> > >>>>>>>>>
> >> > >>>>>>>>>> +1
> >> > >>>>>>>>>>
> >> > >>>>>>>>>> SUCCESS! [0:29:50.184640]
> >> > >>>>>>>>>>
> >> > >>>>>>>>>> Kevin Risden
> >> > >>>>>>>>>>
> >> > >>>>>>>>>>
> >> > >>>>>>>>>> On Thu, Oct 27, 2022 at 9:34 AM Jan Høydahl <
> >> > >>>>> jan....@cominvent.com>
> >> > >>>>>>>>> wrote:
> >> > >>>>>>>>>>
> >> > >>>>>>>>>>> +1
> >> > >>>>>>>>>>>
> >> > >>>>>>>>>>> SUCCESS! [0:44:05.588102]
> >> > >>>>>>>>>>>
> >> > >>>>>>>>>>> Also built docker image, confirming it uses
> >> > >>>>>>>>> eclipse-temurin:17-jre-focal
> >> > >>>>>>>>>>> and starts with flag
> >> > >>>>>>>>>>>
> >> > >>>>>>>>>>
> >> > >>>>>>>>>
> >> > >>>>>>>>
> >> > >>>>>>>
> >> > >>>>>
> >> > >>>
> >> > >>>
> >> > >>
> >> > >
> >> >
> >>
> -XX:CompileCommand=exclude,com.github.benmanes.caffeine.cache.BoundedLocalCache:
> >> > >>> :put
> >> > >>>>>>>>>>>
> >> > >>>>>>>>>>> Jan
> >> > >>>>>>>>>>>
> >> > >>>>>>>>>>>> 27. okt. 2022 kl. 10:25 skrev Ishan Chattopadhyaya <
> >> > >>>>>>>>>>> ichattopadhy...@gmail.com>:
> >> > >>>>>>>>>>>>
> >> > >>>>>>>>>>>> Please vote for release candidate 1 for Solr 9.1.0
> >> > >>>>>>>>>>>>
> >> > >>>>>>>>>>>> The artifacts can be downloaded from:
> >> > >>>>>>>>>>>>
> >> > >>>>>>>>>>>
> >> > >>>>>>>>>>
> >> > >>>>>>>>>
> >> > >>>>>>>>
> >> > >>>>>>>
> >> > >>>>>
> >> > >>>
> >> > >>>
> >> > >>
> >> > >
> >> >
> >>
> https://dist.apache.org/repos/dist/dev/solr/solr-9.1.0-RC1-rev-eadc4178b30af782a
> >> > >>> 21cb739122a1bafbc6ae99b
> >> > >>> <
> >> > >>
> >> > >
> >> >
> >>
> https://dist.apache.org/repos/dist/dev/solr/solr-9.1.0-RC1-rev-eadc4178b30af782a
> >> > > 21cb739122a1bafbc6ae99b
> >> > >>>
> >> > >>>>>>>>>>>>
> >> > >>>>>>>>>>>> You can run the smoke tester directly with this command:
> >> > >>>>>>>>>>>>
> >> > >>>>>>>>>>>> python3 -u dev-tools/scripts/smokeTestRelease.py \
> >> > >>>>>>>>>>>>
> >> > >>>>>>>>>>>
> >> > >>>>>>>>>>
> >> > >>>>>>>>>
> >> > >>>>>>>>
> >> > >>>>>>>
> >> > >>>>>
> >> > >>>
> >> > >>>
> >> > >>
> >> > >
> >> >
> >>
> https://dist.apache.org/repos/dist/dev/solr/solr-9.1.0-RC1-rev-eadc4178b30af782a
> >> > >>> 21cb739122a1bafbc6ae99b
> >> > >>> <
> >> > >>
> >> > >
> >> >
> >>
> https://dist.apache.org/repos/dist/dev/solr/solr-9.1.0-RC1-rev-eadc4178b30af782a
> >> > > 21cb739122a1bafbc6ae99b
> >> > >>>
> >> > >>>>>>>>>>>>
> >> > >>>>>>>>>>>> You can build a release-candidate of the official docker
> >> > >>>>> image
> >> > >>>>>>>> using
> >> > >>>>>>>>>> the
> >> > >>>>>>>>>>>> following command:
> >> > >>>>>>>>>>>>
> >> > >>>>>>>>>>>> DIST_BASE=https://dist.apache.org/repos/dist/dev/solr
> >> > >> &&
> >> > >>> \
> >> > >>>>>>>>>>>>
> >> > >>>>>>>>>
> >> > >>>>>
> >> RC_FOLDER=solr-9.1.0-RC1-rev-eadc4178b30af782a21cb739122a1bafbc6ae99b
> >> > >>>>>>>>>>> && \
> >> > >>>>>>>>>>>> docker build
> >> > >>>>>>>> $DIST_BASE/$RC_FOLDER/solr/docker/Dockerfile.official \
> >> > >>>>>>>>>>>> --build-arg
> >> > >>>>>>>>>> SOLR_DOWNLOAD_URL=$DIST_BASE/$RC_FOLDER/solr/solr-9.1.0.tgz
> >> > >>>>>>>>>>> \
> >> > >>>>>>>>>>>> -t solr-rc:9.1.0-1
> >> > >>>>>>>>>>>>
> >> > >>>>>>>>>>>> The vote will be open for at least 72 hours i.e. until
> >> > >>>>> 2022-10-30
> >> > >>>>>>>>> 09:00
> >> > >>>>>>>>>>> UTC.
> >> > >>>>>>>>>>>>
> >> > >>>>>>>>>>>> [ ] +1  approve
> >> > >>>>>>>>>>>> [ ] +0  no opinion
> >> > >>>>>>>>>>>> [ ] -1  disapprove (and reason why)
> >> > >>>>>>>>>>>>
> >> > >>>>>>>>>>>> Here is my +1
> >> > >>>>>>>>>>>> ----
> >> > >>>>>>>>>>>
> >> > >>>>>>>>>>>
> >> > >>>>>>>>>>>
> >> > >>>>>>>
> >> > >>>
> >> ---------------------------------------------------------------------
> >> > >>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org
> >> > >>>>>>>>>>> For additional commands, e-mail: dev-h...@solr.apache.org
> >> > >>>>>>>>>>>
> >> > >>>>>>>>>>>
> >> > >>>>>>>>>>
> >> > >>>>>>>>>
> >> > >>>>>>>>
> >> > >>>>>>>
> >> > >>>>>>>
> >> > >>>>>>> --
> >> > >>>>>>> -----------------------------------------------------
> >> > >>>>>>> Noble Paul
> >> > >>>>>>>
> >> > >>>>>
> >> > >>>>>
> >> ---------------------------------------------------------------------
> >> > >>>>> To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org
> >> > >>>>> For additional commands, e-mail: dev-h...@solr.apache.org
> >> > >>>>>
> >> > >>>>>
> >> > >>>
> >> > >>>
> >> > >>>
> >> > >>
> >> > >> --
> >> > >> http://www.needhamsoftware.com <http://www.needhamsoftware.com/>
> >> (work)
> >> > >> http://www.the111shift.com <http://www.the111shift.com/> (play)
> >> >
> >> >
> >>
> >
>
Kevin Risden

Reply via email to