Thanks for the ping and publicity. I just reviewed it again. ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley
On Fri, Mar 24, 2023 at 10:40 AM Eric Pugh <ep...@opensourceconnections.com> wrote: > Hi all, > > I’d love to get some review of the work to migrate the > setDefaultCollection method from the CloudSolrClient to the Builders. > This required updating a LOT of tests. I struggled to not try and > refactor a lot more, and not sure how I did on that. > > I am excited about some other efforts that will make managing SolrClient’s > in tests better, however I’m not sure if it’s worth waiting for those > things to come to fruition before merging this. Getting this PR in means > we can finally close out SOLR-8975, SolrClient setters should be deprecated > in favor of Solr Client Builder methods. > > Here are the links to the issue and the PR ;-) > > https://issues.apache.org/jira/browse/SOLR-10466 < > https://issues.apache.org/jira/browse/SOLR-10466> > https://github.com/apache/solr/pull/1256 < > https://github.com/apache/solr/pull/1256> > > Eric > > > > _______________________ > Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | > http://www.opensourceconnections.com < > http://www.opensourceconnections.com/> | My Free/Busy < > http://tinyurl.com/eric-cal> > Co-Author: Apache Solr Enterprise Search Server, 3rd Ed < > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw> > > This e-mail and all contents, including attachments, is considered to be > Company Confidential unless explicitly stated otherwise, regardless of > whether attachments are marked as such. > >
