Thanks for bringing it to my attention; I haven't run bats before. There are two tests in that test file: the sysprop one was failing and the ENV one was passing. But this is actually misleading because the affinity plugin choice is only used in the sysprop one and it was this which caused the failure, which I was able to prove by temporarily changing the ENV one to also use affinity and it failed. So the Affinity plugin probably calculates something based on computer / environmental factors differently on Crave's build machine versus some other environments. Hmmmm. There is a unit test for the plugin but it passes everywhere.
Separately from this matter, there were some issues with reconfiguring the job to use Crave. The Jenkins jobs want various files like unit test output so that reports can be generated. Crave can pull back this stuff but I had to figure out how to run this separate command even if the tests failed. I hopefully just fixed that but it's an iterative process to see. ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Wed, Apr 12, 2023 at 11:10 AM Houston Putman <hous...@apache.org> wrote: > Hey David, > > I think enabling this has caused one integration test to start failing: > > "Affinity placement plugin using ENV" in the test_placement_plugin.bats > file. > (It's incorrectly named, but that's another issue). > > It's been failing consistently since April 6, and does not reproduce > locally. > > - Houston > > On Fri, Mar 31, 2023 at 6:24 PM David Smiley <dsmi...@apache.org> wrote: > > > FYI next Friday, I intend to change one of our CI builds such as > > https://ci-builds.apache.org/job/Solr/job/Solr-Check-9.x/ to use Crave > to > > run a build to see how it performs. I'll be doing this in > > collaboration/partnership with Uv. The builds take ~52minutes now but > > could easily be less than 10 using the same hardware that Crave uses to > run > > our PR builds. I will ensure we retain test reports, logs, and other > info > > as we see now. > > > > ~ David Smiley > > Apache Lucene/Solr Search Developer > > http://www.linkedin.com/in/davidwsmiley > > >
