I'm trying to figure out how best to reproduce a patch failure that is causing the automated Github Action (GHA) on the PR to fail. And now that I think about it, I realized that looking at Isabelle's git clone is not going to help: The git clone + PR patch process that GHA does, is the one I need to reproduce. IIUC, that means I will need to reproduce whatever the "checkout@v3" action does and then go from there.
Let me think about how to do that. Thanks, -Uv On Aug 30 2023, at 8:34 pm, Alex Deparvu <stilla...@apache.org> wrote: > Hi, > > Sorry but I find your request very odd. what would her machine have that > the PR doesn't contain, and why would any of this impact the crave builds? > > If you want to take a look, the PR in question is > https://github.com/apache/solr/pull/1632 > The branch that originates the PR is > https://github.com/igiguere/solr/tree/SOLR-14886-Suppress_stack_trace_in_Query_response > And I would assume the key to this mystery lies in how far it drifted from > main without being rebased: This branch is 12 commits ahead, 6 commits > behind apache:main. > > I have not followed the crave builds discussions very closely, but if I may > offer some debugging idea: if applying the > 'magic_build_formula(main_branch, PR_branch)' is failing and you'd like a > reproduce, I would try to: fork Solr main branch with the history intact -> > which gives you main_branch_local, fork this PR's repo (or just pickup the > specific branch with its history intact) which gives you PR_branch_local. > then debug 'magic_build_formula(main_branch_local, PR_branch_local)'. same > formula should result in the same failures I assume. this is all open > source in the end, all data should be available to you already. > > Otherwise if you look at older PRs (month+) you'll find other examples > pretty quickly, here is one I'm working on that seem to have the same > troubles https://github.com/apache/solr/pull/1119 > > I hope this helps, > alex > > > > On Wed, Aug 30, 2023 at 4:50 PM Yuvraaj Kelkar <yuvr...@gmail.com> wrote: > > Hi Isabelle, > > > > I'm from the Crave team who's trying to figure out the PR patching problem. > > I'd like to be able to debug your PR. > > > > I will need to understand what your patch looks like on your machine. > > Will you be willing to join a Zoom call where I guide you to run a few git > > commands? > > This will really help me figure out whats going on, and then recommend > > steps to move your PR forward. > > > > Thanks, > > -Uv > > > > On Aug 25 2023, at 10:00 am, Isabelle Giguere > > <igigu...@opentext.com.invalid> wrote: > > > Hi again; > > > > > > My PR build keeps failing because of unrelated patches being applied. > > > The PR branch has no conflicts with master, and the fork is up-to-date > > (as of writing this, could change any minute), so I don't understand why > > these patches are being applied. > > > Note that I will not have time to look into this in the next few weeks. > > > If anyone with some knowledge of SOLR-16861 and/or SOLR-16809 wants to > > look into this, feel free to use the fork. > > > Thank you > > > ------------------------------ > > > Applying: SOLR-16861: Correct(override) MDC info forerror: patch failed: > > solr/core/src/java/org/apache/solr/core/NodeConfig.java:145 > > > error: solr/core/src/java/org/apache/solr/core/NodeConfig.java: patch > > does not apply > > > hint: Use 'git am --show-current-patch=diff' to see the failed patch > > > `CoordinatorHttpSolrCall` (#1753) > > > Applying: SOLR-15734: Add "Major Changes" note for 9.3 v2 API changes > > > Applying: SOLR-16809: Converge logic for hidden sysProps > > > > > > Patch failed at 0115 SOLR-16809: Converge logic for hidden sysProps > > > ... > > > ------------------------------- > > > > > > Isabelle Giguère > > > > > > ________________________________ > > > De : Isabelle Giguere <igigu...@opentext.com.INVALID> > > > Envoyé : 23 août 2023 15:13 > > > À : Mike Drob <md...@mdrob.com> > > > Cc : dev solr <dev@solr.apache.org> > > > Objet : Re: [EXTERNAL] - Re: PR reviewed > > > > > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you recognize the sender and know > > the content is safe. If you feel that the email is suspicious, please > > report it using PhishAlarm. > > > > > > Hi Mike; > > > Thanks for the heads-up. > > > Task "validateSourcePatterns" fails if there's no logger specific to the > > test class! > > > I'll fix that... But... Should "validateSourcePatterns" be so picky > > about logging in test classes? > > > Just a thought. > > > > > > Isabelle Giguère > > > > > > ________________________________ > > > De : Mike Drob <md...@mdrob.com> > > > Envoyé : 23 août 2023 12:14 > > > À : Isabelle Giguere <igigu...@opentext.com> > > > Cc : dev solr <dev@solr.apache.org> > > > Objet : [EXTERNAL] - Re: PR reviewed > > > > > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you recognize the sender and know > > the content is safe. If you feel that the email is suspicious, please > > report it using PhishAlarm. > > > Resending with corrected email address > > > On Wed, Aug 23, 2023 at 11:13 AM Mike Drob <md...@mdrob.com<mailto: > > md...@mdrob.com>> wrote: > > > Hi Isabelle, > > > > > > It looks like there is a precommit check issue with the code still, can > > you take a look and address that? You should be able to click on "details" > > for the failing check, or run it locally using ./gradlew check -x test > > > Thanks for your contribution! > > > On Wed, Aug 23, 2023 at 9:52 AM Isabelle Giguere > > <igigu...@opentext.com.invalid> wrote: > > > Hello Solr committers! > > > > > > This PR was reviewed by Christine Poerschke< > > https://urldefense.com/v3/__https://github.com/cpoerschke__;!!Obbck6kTJA!duKnEIiSaXVHBEWj835rekhNLQQNmKDttzEvh0as8goQtakJlinf3RMOV1dceYMQVHMyxeHHQXhYjZ0AqmqjPupy72w$ > > < > > https://urldefense.com/v3/__https://github.com/cpoerschke__;!!Obbck6kTJA!apdgjI2Vf7UM6mj_LfBCJLMlYsIQTv5AmJN5uV6Jp8Bw9pO7Uw8kGnMJtHAmpjWqSaPV3UHSzhcbBw$>> > > and Alex D< > > https://urldefense.com/v3/__https://github.com/stillalex__;!!Obbck6kTJA!duKnEIiSaXVHBEWj835rekhNLQQNmKDttzEvh0as8goQtakJlinf3RMOV1dceYMQVHMyxeHHQXhYjZ0AqmqjIprbmAI$ > > < > > https://urldefense.com/v3/__https://github.com/stillalex__;!!Obbck6kTJA!apdgjI2Vf7UM6mj_LfBCJLMlYsIQTv5AmJN5uV6Jp8Bw9pO7Uw8kGnMJtHAmpjWqSaPV3UHitnUfYw$>>. > > Thank you both 🙂 > > > IMHO, the code is as clean as it's going to get. I hope it can be merged > > some day. > > > > > https://urldefense.com/v3/__https://github.com/apache/solr/pull/1632__;!!Obbck6kTJA!duKnEIiSaXVHBEWj835rekhNLQQNmKDttzEvh0as8goQtakJlinf3RMOV1dceYMQVHMyxeHHQXhYjZ0AqmqjSTGD-Bw$ > > < > > https://urldefense.com/v3/__https://github.com/apache/solr/pull/1632__;!!Obbck6kTJA!apdgjI2Vf7UM6mj_LfBCJLMlYsIQTv5AmJN5uV6Jp8Bw9pO7Uw8kGnMJtHAmpjWqSaPV3UHpLPkKqA$ > > > > > > Regards; > > > Isabelle Giguère >
