Okay, sounds good. Thanks for the clarification. On Thu, 30 Nov, 2023, 10:31 pm Jason Gerlowski, <gerlowsk...@gmail.com> wrote:
> Houston and Eric's latest comments match what I was aiming for. > > "Approximate /select" isn't a new endpoint in Solr, it's a stopgap for > client-generation only. Describing Solr's complex query syntax in an OAS > is going to take some time - this just gives users of our generated clients > a way to run simple queries in that interim. > > The commit message gets into a bit more detail here: > > > Now that Solr uses its OAS to generate client bindings in multiple > > languages (Java and JavaScript, so far), users of these clients may wish > > to use them to run searches. > > > Normally, this would require converting the `/select` endpoint to JAX-RS > > so that its inputs and outputs can be described comprehensively in our > > OAS. However, doing this for `/select` will take some time due to the > > complexity and large degree of configurability the endpoint offers. > > > This commit works around this limitation by creating an approximation of > > the `/select` endpoint that can appear in our OAS until the API can be > > converted to JAX-RS in earnest. This will give generated-client users > > access to at least some query functionality in this interim. > > Anyway, that's what I was TRYING to do. Like Mike said though - I'm happy > to tweak things if there's an alternate approach we can agree is better? > > Best, > > Jason > > On Thu, Nov 30, 2023 at 10:04 AM Houston Putman <hous...@apache.org> > wrote: > > > Yeah, Eric that's correct. No fragmentation happening. > > > > Ishan, if you look at the PR, no handlers were added. > > > > - Houston > > > > On Thu, Nov 30, 2023 at 9:56 AM Eric Pugh < > ep...@opensourceconnections.com > > > > > wrote: > > > > > Assuming I understand correctly, this isn’t a new /select end point. > > > It’s still the same familiar /select end point. It’s about making > sure > > > that our generated client, which currently supports *some* endpoints > in a > > > very structured way, can also be used to issue queries. > > > > > > Right now, the client does some valuable stuff, but frequently you want > > to > > > issue a query, and you can’t use the client for that side. This lets > an > > > end user install one client, and work with both the /select end point, > > but > > > also the more highly structured apis. > > > > > > > > > > > > > On Nov 30, 2023, at 9:33 AM, Ishan Chattopadhyaya < > > > ichattopadhy...@gmail.com> wrote: > > > > > > > > Having a /select and a similar (approximate) endpoint that is not > > exactly > > > > like /select but similar will create fragmentation. Having an > > > automatically > > > > generated client is not a goal worthy of sacrificing on API > consistency > > > (by > > > > creating a separate /select like endpoint). > > > > > > > > On Wed, 29 Nov, 2023, 10:23 pm gerlowskija (via GitHub), < > > g...@apache.org > > > > > > > > wrote: > > > > > > > >> > > > >> gerlowskija merged PR #2079: > > > >> URL: https://github.com/apache/solr/pull/2079 > > > >> > > > >> > > > >> -- > > > >> This is an automated message from the Apache Git Service. > > > >> To respond to the message, please log on to GitHub and use the > > > >> URL above to go to the specific comment. > > > >> > > > >> To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org > > > >> > > > >> For queries about this service, please contact Infrastructure at: > > > >> us...@infra.apache.org > > > >> > > > >> > > > >> > --------------------------------------------------------------------- > > > >> To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org > > > >> For additional commands, e-mail: issues-h...@solr.apache.org > > > >> > > > >> > > > > > > _______________________ > > > Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 > | > > > http://www.opensourceconnections.com < > > > http://www.opensourceconnections.com/> | My Free/Busy < > > > http://tinyurl.com/eric-cal> > > > Co-Author: Apache Solr Enterprise Search Server, 3rd Ed < > > > > > > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw > > > > > > > > > This e-mail and all contents, including attachments, is considered to > be > > > Company Confidential unless explicitly stated otherwise, regardless of > > > whether attachments are marked as such. > > > > > > > > >
