> I come back to Solr only about once a year Well welcome back!
> implementing everything needed for clustersizing v2 would be a long and > difficult process for me [...] I can push what I have, but then I think > should make the PR a draft, and hope for participation from other > contributors. And of course! Not everyone has the time, or inclination, or context to get every PR totally finished on their own. Totally understandable - it comes up a lot. And the advice we usually give is that all contributions - even those that are incomplete, undocumented, etc. - are worth sharing so that others can build off of them and hopefully close whatever gaps remain. The only thing you need to do in that case is make sure the known gaps are mentioned somewhere - which you already sort of did above, so you're all set! Best, Jason On Wed, Apr 10, 2024 at 4:24 PM Isabelle Giguere <igigu...@opentext.com.invalid> wrote: > > Thanks for the feedback. > > I'm trying to implement V2. > API interface, annotated response class: easy. > > Now I'm stuck. > All the examples I can find in CollectionHandler (where clustersizing > resides) call CollectionsHandler.submitCollectionApiCommand(...), which > requires an implementation of interface CollectionApiCommand, which was never > implemented for clustersizing. > > I come back to Solr only about once a year, and usually to apply some old > patch on a more recent version. That means I have a limited understanding of > what ties into what and why. So, implementing everything needed for > clustersizing v2 would be a long and difficult process for me. > > I can push what I have, but then I think should make the PR a draft, and hope > for participation from other contributors. > > > Isabelle Giguère > Computational Linguist & Java Developer > Linguiste informaticienne & développeur java > > > ________________________________ > De : Gus Heck <gus.h...@gmail.com> > Envoyé : 9 avril 2024 11:15 > À : dev@solr.apache.org <dev@solr.apache.org> > Objet : [EXTERNAL] - Re: PR ready fro review > > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. If you feel that the email is suspicious, please report it > using PhishAlarm. > > > +1 for v2 in same PR > > On Tue, Apr 9, 2024 at 10:15 AM Jason Gerlowski <gerlowsk...@gmail.com> > wrote: > > > > V2 could be handled in a different PR, if preferable. > > > > My preference at least would be that v2 is added in the same PR, so > > there's no chance it falls through the cracks. > > > > I haven't found time to review yet, but I've put this on my list and > > will try to come back through this week at some point. If I happen to > > forget, feel free to ping me (@gerlowskija) on the PR if I haven't > > reviewed by Thursday or Friday. > > > > On Tue, Apr 9, 2024 at 8:29 AM Eric Pugh > > <ep...@opensourceconnections.com> wrote: > > > > > > I put some comments in. On the V2 api, I think that if this is > > specific to a collection, then /api/collections/cluster-size or maybe even > > /api/collections/sizing ???? If it’s overall, and not collection > > specific, then /api/cluster/sizing would make sense. And if it supports > > both, well then it could be both patterns! > > > > > > Jason G might have more insight on the best path…. > > > > > > > On Apr 8, 2024, at 5:02 PM, Isabelle Giguere > > <igigu...@opentext.com.INVALID> wrote: > > > > > > > > Hello committers; > > > > > > > > Please take some time to review this PR : > > > > https://urldefense.com/v3/__https://github.com/apache/solr/pull/1638__;!!Obbck6kTJA!aD_c0LMFWboisH1fRZUyMdHu2BNU7KuwCCbeTetcPxm_kPggNqQk6TGSpDNKoCY2bcUYyNn3QQ13OIX6Tw$ > > > > > > > > It is based on a rather old patch, so only V1 is supported, for now. > > > > > > > > If we wanted V2, what should be the URL path ? > > > > > > > > * > > > > /api/collections/cluster-size > > > > * > > > > /api/cluster/sizing > > > > > > > > V2 could be handled in a different PR, if preferable. > > > > > > > > Thank you; > > > > > > > > Isabelle Giguère > > > > Computational linguist & Java developer | Engineering > > > > Linguiste informaticienne & développeur java | Engineering > > > > > > > > Phone: (514) 908 5406 ext. 75125 > > > > Website: https://www.opentext.com/ > > > > > > > > > > > > [ > > https://mimage.opentext.com/alt_content/binary/images/email-signature/ot2023-corporate-email-signature-370x70-fy24-2-retina.png > > ]<https://www.opentext.com/> > > > > > > > > This email message is confidential, may be privileged, and is intended > > for the exclusive use of the addressee. Any other person is strictly > > prohibited from disclosing or reproducing it. If the addressee cannot be > > reached or is unknown to you, please inform the sender by return email and > > delete this email message and all copies immediately. > > > > > > _______________________ > > > Eric Pugh | Founder | OpenSource Connections, LLC | 434.466.1467 | > > https://urldefense.com/v3/__http://www.opensourceconnections.com__;!!Obbck6kTJA!aD_c0LMFWboisH1fRZUyMdHu2BNU7KuwCCbeTetcPxm_kPggNqQk6TGSpDNKoCY2bcUYyNn3QQ0eMqTnPQ$ > > < > > https://urldefense.com/v3/__http://www.opensourceconnections.com/__;!!Obbck6kTJA!aD_c0LMFWboisH1fRZUyMdHu2BNU7KuwCCbeTetcPxm_kPggNqQk6TGSpDNKoCY2bcUYyNn3QQ1DDZRweg$ > > > | My Free/Busy < > > https://urldefense.com/v3/__http://tinyurl.com/eric-cal__;!!Obbck6kTJA!aD_c0LMFWboisH1fRZUyMdHu2BNU7KuwCCbeTetcPxm_kPggNqQk6TGSpDNKoCY2bcUYyNn3QQ0P3iDFzQ$ > > > > > > Co-Author: Apache Solr Enterprise Search Server, 3rd Ed < > > https://urldefense.com/v3/__https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw__;!!Obbck6kTJA!aD_c0LMFWboisH1fRZUyMdHu2BNU7KuwCCbeTetcPxm_kPggNqQk6TGSpDNKoCY2bcUYyNn3QQ2SFo_ftQ$ > > > > > > This e-mail and all contents, including attachments, is considered to be > > Company Confidential unless explicitly stated otherwise, regardless of > > whether attachments are marked as such. > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org > > For additional commands, e-mail: dev-h...@solr.apache.org > > > > > > -- > https://urldefense.com/v3/__http://www.needhamsoftware.com__;!!Obbck6kTJA!aD_c0LMFWboisH1fRZUyMdHu2BNU7KuwCCbeTetcPxm_kPggNqQk6TGSpDNKoCY2bcUYyNn3QQ2lM7iBAA$ > (work) > https://urldefense.com/v3/__https://a.co/d/b2sZLD9__;!!Obbck6kTJA!aD_c0LMFWboisH1fRZUyMdHu2BNU7KuwCCbeTetcPxm_kPggNqQk6TGSpDNKoCY2bcUYyNn3QQ2LLqkNrQ$ > (my fantasy fiction book) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org For additional commands, e-mail: dev-h...@solr.apache.org
