I'm probably not a great reviewer of this TBH as I have only heard & read about lucene-monitor/percolator; haven't used such a thing yet.
I did a *quick* review to see how the PR touches the codebase. It's wonderful that it is purely isolated; it requires no changes of Solr itself. I might argue why is it here vs the Solr sandbox or somewhere else with publicity in http://solr.cool The name "Monitor" sounds like an infrastructure monitoring feature. p.s. I'm on vacation this week with minimal time to collaborate On Mon, Apr 15, 2024 at 10:27 AM Luke Kot-Zaniewski (BLOOMBERG/ 919 3RD A) <lkotzanie...@bloomberg.net> wrote: > > Hey David, > > Just wanted to bump this. I appreciate you taking a look, and wanted to > stress that I am looking for even just higher level feedback at this point. > > Basically, I am questioning the direction I am going in which involves > exposing some of the lucene-monitor internals (so currently have an implicit > dependence on a lucene change). OTOH I couldn't figure out a better way to > apply the lucene-monitor optimizations while still utilizing solr's > sophisticated index management and scaling. Lucene-monitor is a very sealed > interface and the way it manages the index and caching (via Monitor > interface) is not easy to integrate on its own. > > Again, I'd appreciate any feedback, even partial, that you may have! > > Thanks, > Luke > > From: dev@solr.apache.org At: 04/08/24 13:43:52 UTC-4:00To: > dev@solr.apache.org > Subject: Re: solr query alerting > > I'm so glad someone has started this! Thanks for contributing. I'll > take a look > > On Mon, Apr 1, 2024 at 3:53 PM Luke Kot-Zaniewski (BLOOMBERG/ 919 3RD > A) <lkotzanie...@bloomberg.net> wrote: > > > > Hi All, > > > > A few months ago I wrote the user list about potentially integrating lucene > monitor into solr. I have raised this PR with a first attempt at implementing > this integration. I'd greatly appreciate any feedback on this even though I > still have it marked as draft. I want to make sure I'm heading in the right > direction here so input from solr dev community would be extremely valuable > :-) > > > > Many thanks, > > Luke > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org > For additional commands, e-mail: dev-h...@solr.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org For additional commands, e-mail: dev-h...@solr.apache.org
