> One question that popped up recently (Jan can probably answer that): > > If I create a PR for backporting a cherry-picked commit that was previously > completed with Solrbot, will the CHANGES file be updated by the bot? If not, > I believe that I should update that in the PR myself, right?
A cherry pick and PR against branch_9x will keep "solrbot" as the committer, you who push the "merge" button will be the one "pushing". So as long as the git history has "solrbot" as committer it will be included in CHANGES during the release. > I would like to create for all backports pull requests, even if it is a > simple cherry-pick where the tests succeed. Is this the recommended approach > in this situation? And to not get blocked I would probably not wait for a > reviewer if the tests pass. You can do this if you wish. Or you can have a look at dev-tools/scripts/cherrypick.sh which can do the most simple backports including "gradlew check -x test" and push for you. I tend to use it first, and if it fails due to merge conflict, I fix it and run a manual gradlew check, but if the PR is more involved or include additional commits by me, I go the PR route. Jan --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org For additional commands, e-mail: dev-h...@solr.apache.org
