Hi Jason, hi all, Checking in to see if there’s been any opportunity to review the Azure Blob Storage Backup Repository PR (SOLR-17949): https://github.com/apache/solr/pull/3750
Totally understand everyone's busy — happy to split this into smaller pieces if that helps. Although the diff shows ~70 files changed, the actual implementation is focused on about 16 files total (8 main files and 8 test files). The rest are license header updates. Thank you again for your time and guidance — really appreciate it! Thank you, Prateek Singhal (prateeksolr) On Thu, Oct 30, 2025 at 3:47 PM Prateek Singhal <[email protected]> wrote: > Hi Jason, > > Thanks a lot for taking the time to look at this — really appreciate it! > > I totally understand about the PR size; I'm happy to split it up if that > helps with the review. The functional code is contained in about 10 files > (5 implementation + 5 test), while the rest are mainly license header > updates. > > I can create a smaller “base module” PR first and follow up with a > separate one for tests and docs, if that’s easier to go through. > > Thanks again for reviewing — looking forward to your feedback! > > Thank you, > > Prateek Singhal > > On Wed, Oct 29, 2025 at 7:18 AM Jason Gerlowski <[email protected]> > wrote: > >> Hey Prateek, >> >> IMO this is an awesome idea to round out our compatibility with the >> popular object-stores out there! I haven't had a chance yet, but I'm >> hoping to take a look at the PR shortly. I opened it up yesterday and >> was a little daunted by the size of the PR (5k LOC!), as you pointed >> out. Will keep an eye out as I'm reviewing for potential ways to >> break it into separate PRs, but obviously that's not always possible. >> Hope to provide more feedback shortly! >> >> Best, >> >> Jason >> >> On Wed, Oct 29, 2025 at 12:50 AM Prateek Singhal >> <[email protected]> wrote: >> > >> > Hi all, >> > >> > Just following up on this thread to see if anyone might have time to >> review >> > the Azure Blob Storage Backup Repository PR: >> > https://github.com/apache/solr/pull/3750 >> > <https://github.com/apache/solr/pull/3750?utm_source=chatgpt.com> >> > >> > I realize it’s a large diff (~70 files), but the actual implementation >> is >> > focused on about 10 files (5 main code files and 5 test files); the rest >> > are license header updates. >> > >> > Since this module mirrors the existing s3-repository design, I’d love >> > feedback on structure, config parity, and test coverage to ensure it >> aligns >> > with existing cloud repository modules. >> > >> > Happy to break it into smaller PRs or add more docs if that helps >> review. >> > >> > Thanks again for your time and guidance! >> > >> > Prateek Singhal (prateeksolr) >> > >> > On Thu, Oct 9, 2025 at 7:52 PM Prateek Singhal < >> [email protected]> >> > wrote: >> > >> > > Hi Solr Community, >> > > >> > > I’ve opened a pull request to add an *Azure Blob Storage backup >> > > repository module* to Solr: >> > > >> > > https://github.com/apache/solr/pull/3750 >> > > <https://github.com/apache/solr/pull/3750?utm_source=chatgpt.com> >> > > >> > > *JIRA:* https://issues.apache.org/jira/browse/SOLR-17949 >> > > < >> https://issues.apache.org/jira/browse/SOLR-17949?utm_source=chatgpt.com> >> > > >> > > This module introduces native integration with Azure Blob Storage for >> Solr >> > > backups and restores, extending the existing cloud storage options >> (S3, >> > > GCS, etc.). >> > > It implements the BackupRepository interface and supports multiple >> > > authentication mechanisms: >> > > >> > > - >> > > >> > > Account key–based auth >> > > - >> > > >> > > SAS token–based auth >> > > - >> > > >> > > Service principal–based auth (via Client ID/Secret) >> > > - >> > > >> > > Managed identity–based auth (for Azure-hosted Solr instances) >> > > >> > > The module also supports Azurite, allowing local testing and CI >> validation >> > > without requiring Azure credentials. >> > > ------------------------------ >> > > >> > > *WHY IT’S USEFUL* >> > > >> > > - >> > > >> > > Many organizations use Azure for cloud storage. >> > > - >> > > >> > > Provides a cost-effective backup solution for Azure-hosted Solr >> > > instances. >> > > - >> > > >> > > Supports enterprise-grade authentication via Azure AD. >> > > >> > > ------------------------------ >> > > >> > > *KEY HIGHLIGHTS* >> > > >> > > - >> > > >> > > Mirrors the structure and configuration of the existing >> s3-repository >> > > module for consistency. >> > > - >> > > >> > > Adds a new azure-blob-repository module under modules/. >> > > - >> > > >> > > Includes integration tests for backup/restore and authentication >> flows. >> > > - >> > > >> > > Compatible with Solr 10.x and Java 17+. >> > > - >> > > >> > > Reference Guide (Backup & Restore section) updated with usage >> > > instructions and configuration examples. >> > > >> > > ------------------------------ >> > > >> > > I’d appreciate feedback on: >> > > >> > > - >> > > >> > > The overall module structure and naming conventions. >> > > - >> > > >> > > Parity with other repository modules (configuration parameters, >> error >> > > handling). >> > > - >> > > >> > > Suggestions for test coverage, documentation layout, or dependency >> > > management. >> > > >> > > Once the module stabilizes, I plan to follow up with updates in the >> Solr >> > > Operator to add Azure backup support. >> > > >> > > Thanks in advance for taking the time to review and share your >> feedback! >> > > >> > > Thank you, >> > > Prateek Singhal >> > > (prateeksolr) >> > > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >>
