Sounds good; thank you for unblocking the build with JDK 25. On Tue, Jun 30, 2026 at 10:53 AM Serhiy Bzhezytskyy < [email protected]> wrote:
> Hi all, > > Solr's spotless/tidy currently pins google-java-format 1.18.1. That > version calls javac internals > (Log$DeferredDiagnosticHandler.getDiagnostics()) whose signatures changed > in JDK 24, so `gradlew tidy`/`spotlessApply` throws NoSuchMethodError on > JDK 24+. google-java-format 1.34.0+ adds support for the newer JDKs; 1.35.0 > is the current release. > > I'd like to bump it to 1.35.0. The change is small: > - gradle/libs.versions.toml: google-javaformat 1.18.1 -> 1.35.0 > - re-running the formatter (`gradlew tidy`) reformats ~35 files (minor, > mechanical — the new version's formatting rules) > - spotless (8.3.0) drives the new formatter version with no other change > > I have this on a branch, rebased on current main; `gradlew > spotlessJavaCheck` passes on JDK 21 and (with this bump) on JDK 25. > > Before opening a PR: is anyone already on this, and any objection to 1.35.0 > specifically? I'll create a JIRA and open a focused PR if there's no > concern. > > Thanks, > Serhiy >
