During a few days riding across the Argentinian pampas in a car, I poked around 
in the Solr Java code and did some cleanups group by major package:


https://github.com/apache/solr/pull/4657
https://github.com/apache/solr/pull/4658
https://github.com/apache/solr/pull/4669

It was a mix of typos, methods no longer used, and a lot of java keywords like 
public and static on Java Interfaces.   These were all pretty mechanical 
changes inspired by IntelliJ warnings.    

I didn’t deprecate the unused methods in main, under the theory they aren’t 
used, so we don’t need that.   I *could* if we thought that was important when 
back porting to branch_10x, which I think all three PR’s can do pretty easily.  
Would love some +1’s on them.

Eric

Disclaimer

The information contained in this communication from the sender is 
confidential. It is intended solely for use by the recipient and others 
authorized to receive it. If you are not the recipient, you are hereby notified 
that any disclosure, copying, distribution or taking action in relation of the 
contents of this information is strictly prohibited and may be unlawful.

This email has been scanned for viruses and malware, and may have been 
automatically archived by Mimecast, a leader in email security and cyber 
resilience. Mimecast integrates email defenses with brand protection, security 
awareness training, web security, compliance and other essential capabilities. 
Mimecast helps protect large and small organizations from malicious activity, 
human error and technology failure; and to lead the movement toward building a 
more resilient world. To find out more, visit our website.

Reply via email to