Hi all, can someone take a looksee at https://github.com/apache/solr/pull/4812, 
"SOLR-18362: remove org.apache.solr.spelling.Token”.  This is a conversion from 
o.a.s.spelling.Token to org.apache.lucene.analysis.TokenStream.   

It was listed as a straight up deprecation removal, but the conversion work 
back when it was deprecated never happened, so it’s both deprecation removal 
and new code!

It all looks reasonable, and the tests pass.  I’ve never worked with Lucene 
spelling, and would love another set of eyes.   

I’m inclined to merge it for 10.1, but would love that second set of eyes!


Eric

Disclaimer

The information contained in this communication from the sender is 
confidential. It is intended solely for use by the recipient and others 
authorized to receive it. If you are not the recipient, you are hereby notified 
that any disclosure, copying, distribution or taking action in relation of the 
contents of this information is strictly prohibited and may be unlawful.

This email has been scanned for viruses and malware, and may have been 
automatically archived by Mimecast, a leader in email security and cyber 
resilience. Mimecast integrates email defenses with brand protection, security 
awareness training, web security, compliance and other essential capabilities. 
Mimecast helps protect large and small organizations from malicious activity, 
human error and technology failure; and to lead the movement toward building a 
more resilient world. To find out more, visit our website.

Reply via email to