Thanks David & Eric. I have raised the PR: https://github.com/apache/solr/pull/5221 We can further have discussion over there, if the changes look fine to you, else I also liked David's idea, I can start using IntelliJ configuration as well.
On Sun, Oct 25, 2026 at 8:17 PM Eric Pugh <[email protected]> wrote: > > > On 2026/10/25 12:55:39 David Smiley wrote: > > This has rarely ever been a problem for me because I use IntelliJ > > configured to add the header automatically. > > > > On Sun, Oct 25, 2026 at 2:01 AM Jalaz Kumar <[email protected]> > wrote: > > > > > > Hi all > > > > > > pre-commit (./gradlew check -x test) fails on new files without an ASF > > > license header, which needs to be added by hand when it fails. > > > > > > *Proposal* > > > A small `./gradlew addLicenseHeader` task, similar to > > > `./gradlew writeChangeLog`. > > > > > > *Open Questions* > > > - Is it worth having such a task or is pre-commit failing loudly > enough? > > > - Is covering just the java files enough to start with? > > > - Should it run automatically as part of tidy? -> this will be good. > > > > > > I personally have to manually add the License header on top many times, > > > thus I feel this should help. > > > > > > -- > > > Regards > > > Jalaz Kumar > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > > > I suppose having it be part of tidy if it doesn't slow things down would > be nice. > > The name "tidy" implies you are organizing/fixing things up, and a missing > license header is a example of that! > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Regards Jalaz Kumar
