-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Theo Van Dinter writes:
> Sorry to be a killjoy here.
>
> On Mon, May 09, 2005 at 03:55:07PM -0000, [EMAIL PROTECTED] wrote:
> > + my $redirector_patterns = $self->{conf}->{redirector_patterns};
> > + @uris =
> > Mail::SpamAssassin::Util::uri_list_canonify($redirector_patterns, @uris);
>
> Do we consider uri_list_canonify() to be a public function? If so, there
> needs to be some form of backward compatibility maintained. Since there
> seems to be no POD for Util.pm at all, one could read that to mean it's
> all considered private, but we never did finish going through and changing
> the private function names so it's not clear now.
I don't think it's a particularly public API, since it's called
already by public APIs. in other words I wouldn't worry about
it too much.
As for the rest -- let's just check it in and hack away as Sidney
suggested. ;)
- --j.
> > - my @parsed = $scanner->get_parsed_uri_list();
> > + my @parsed = $scanner->get_uri_list();
>
> -0.7
>
> URIBL now considers the full list of URIs as having been parsed out of
> the rendered text, which messes up the priority levels somewhat. A case can
> be made that the higher priority domains will already be on the list, but it
> does mean more work for the plugin (more URIs to go through).
>
> If we're not changing get_uri_list() (or more likely making a new
> function) to return a combined uri_detail-esque dataset, then I'd like
> to see get_parsed_uri_list() left alone (ie: let it do the canonification
> and get_uri_list() can skip doing it), and just add a call into URIBL to
> get_uri_list (we don't care about the output) to do the canonification
> of the HTML bits.
>
> Arguably, we could just have a new "_canonify_uri_detail()" call in
> PMS and avoid the rest of the get_uri_list() stuff, but ... We know
> get_uri_list() is being called elsewhere anyway, so it's not a big deal IMO.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Exmh CVS
iD8DBQFCgCxiMJF5cimLx9ARApgKAJ99n5wSZoEJB+AI9qHEZBmd46KVkgCfaPOg
sNXOp1xY1o04TA6c3VQfhmE=
=9Jfb
-----END PGP SIGNATURE-----
