http://bugzilla.spamassassin.org/show_bug.cgi?id=3771
------- Additional Comments From [EMAIL PROTECTED] 2004-09-11 14:31 ------- Subject: Re: PostgreSQL Specific Bayes Storage Module On Sat, Sep 11, 2004 at 01:51:12PM -0700, [EMAIL PROTECTED] wrote: > > ------- Additional Comments From [EMAIL PROTECTED] 2004-09-11 13:51 ------- > If our current SQL storage is MySQL-specific, we should call it MySQL and > replace it with a generic SQL one which works with every SQL server. Both > the > MySQL and the PgSQL should be additonal modules (though maybe used more often > than the general one) which are available separately. This bug is actually > one > reason why I wrote the "Our repository structure" mail on [EMAIL PROTECTED] > The current SQL.pm module IS NOT MySQL specific, it should work with a large number of databases, and a great deal of time and effort was put into the code to make it that way. However, it is not optimal for PostgreSQL. The design accounts for this, where needed you subclass SQL.pm and override whatever method you need. If you want to make the token column a bytea type, then you override the 5 or so methods it takes to do that. We're not shipping whole new modules. I do not believe "plugin" in the sense of Mail::SpamAssassin::Plugin makes any sense. Now if you mean interchangeable storage backend as plugin then that is exactly the design of BayesStore and the DBM.pm and SQL.pm modules. If you want something totally different BayesStore has a public API that you write to, these lets you implement storage however you want. Now, if you're talking about making bayes as a whole a plugin, that is a different story. I have never had any intention of support one or two databases only, all comers are welcome. I'm downloading the Oracle 9i install disks as I type this so I can try it out, if it needs tweaks I create a module for them. Same for DB2, same for Sybase so on and so forth. Michael ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
