-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Theo Van Dinter writes: > On Wed, Oct 13, 2004 at 11:53:52AM -0700, Dan Quinlan wrote: > > This code is really getting unreadable and is hard to follow and this > > patch makes it worse, the use of magic numbers like -1 is also bad. > > I think it's like the rest of our code, if you're used to it, it makes sense. > If it doesn't, it takes a little bit. > > I could have used undef instead of -1, but -1 is an invalid received date > which if used before the time is actually determined will at least make it > known what the state is -- undef would throw a warning/etc. I agree with Daniel that "magic numbers" make for hard-to-read code. How's about defining a constant TIME_UNKNOWN_YET or similar, which maps to -1, and using that instead? - --j. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) Comment: Exmh CVS iD8DBQFBbYj8MJF5cimLx9ARAmX1AJ97wR4sOjaLtPWRgur0GnGF4q7n/wCfXhLi e//V6AbMLOomrdFkcoz+zgY= =YtTI -----END PGP SIGNATURE-----
