http://bugzilla.spamassassin.org/show_bug.cgi?id=3936

           Summary: ArchiveIterator uses opt_n for two different things
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Libraries
        AssignedTo: [email protected]
        ReportedBy: [EMAIL PROTECTED]


According to the documentation opt_n specifies whether or not the list of 
messages ought to be sorted 
by received date (see below), but the code also uses opt_n to determine whether 
or not the received 
date should be calculated at all (ie: whether message_is_useful_by_date() is 
called.

I've enabled -n in my nightly mass-check runs for non-Bayes, because the 
sorting is irrelevent without 
Bayes.  However, I use --after to limit the age of the messages that are run.  
What I've found is that --
after is ignored when -n is used, and in looking at the code, opt_n is used for 
both sorting and received 
date useful checks.

Since I really want to change the names of the options (opt_n in the code isn't 
very clear on what it 
means) anyway, I'm planning to make two new options to specify sorting and 
useful checking 
separately, then allow opt_n to set both in a single go for backward 
compatibility.

"=item opt_n

ArchiveIterator is typically used to simulate ham and spam moving through
SpamAssassin.  By default, the list of messages is sorted by received date so
that the mails can be passed through in order.  If opt_n is true, the sorting
will not occur.  This is useful if you don't care about the order of the
messages."



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to