http://bugzilla.spamassassin.org/show_bug.cgi?id=3949
Summary: ALL_TRUSTED misfires when Received: parsing fails. Product: Spamassassin Version: 3.0.1 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Rules (Eval Tests) AssignedTo: dev@spamassassin.apache.org ReportedBy: [EMAIL PROTECTED] ALL_TRUSTED currently only checks to make sure no untrusted relays exist. However, it does not check if any trusted relays exist, causing it to false-match any time Received: header parsing fails, contributing to FP problems. Example debug bits from a list post: debug: received-header: unknown format: debug: received-header: unknown format: debug: received-header: unknown format: debug: received-header: unknown format: debug: metadata: X-Spam-Relays-Trusted: debug: metadata: X-Spam-Relays-Untrusted: debug: tests=ALL_TRUSTED,DRUGS_ERECTILE ... Might I suggest a minor change to the eval, something like this: sub check_all_trusted { my ($self) = @_; if ($self->{num_relays_untrusted} > 0) { return 0; } else { if ($self->{num_relays_trusted} > 0) { return 1; } else { return 0; } } } I'd make a patch, but I'm not perl coder, so I'm not even sure if the above is valid, it's just an illustration of what I think the code should do. ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.