On Friday 03 December 2004 12:43 CET Daniel Quinlan wrote:
> [EMAIL PROTECTED] writes:
> > + dbg("logger: trying to connect to syslog/${log_socket}...\n");
> > + dbg("logger: connection to syslog/${log_socket} failed: $err\n"
> > + dbg("logger: failed to setlogsock(${log_socket}): $err\n"
> > + dbg("logger: successfully connected to syslog/${log_socket}");
> > +dbg("logger: enabled with:\n"
> > + dbg("logger: facility stderr disabled: already debugging to
> > stderr.");
>
> Using "logger" instead of "syslog"? Just wondering.
Yeah, I first called it "syslog" but then remembered that we support logging
to non-syslog targets (like files), too. And the Unix tool is called
"logger", too :) But "syslog" would be fine with me, too.
> > + dbg("daemon: removing stale socket file $path");
> > + dbg("daemon: creating UNIX socket:\n" . join("\n", map { "\t$_: " .
> > (defined $socket{$_} ? $socket{$_} : "(undef)") } sort keys %socket));
> > + dbg("daemon: creating SSL socket:\n" . join("\n", map { "\t$_: " .
> > (defined $socket{$_} ? $socket{$_} : "(undef)") } sort keys %socket));
> > + dbg("daemon: creating INET socket:\n" . join("\n", map { "\t$_: " .
> > (defined $socket{$_} ? $socket{$_} : "(undef)") } sort keys %socket));
> > + dbg('daemon: daemonized.');
> > + dbg("daemon: Preloading modules with HOME=$tmphome");
>
> I'd *much* rather have these say "spamd".
Yeah, I first used "spamd" and in the next patch "daemon" and had to decide
for one of them. It was a 50-50 chance and I already had more "daemon"
entries so changed the "spamd" ones :) Short: I don't care what that
facility is called (as long as its not "foo").
> > +dbg("info: server started on $listeninfo (running version "
> > +dbg("info: server pid: $$\n");
> > + dbg("info: Server socket closed");
>
> Those should be:
>
> info("spamd: server started on $listeninfo (running version "
> info("spamd: server pid: $$\n");
>
> info() is what you call to do info stuff, you still give it a normal
> facility name.
Japp, noticed that too late. But I'm not sure if all of these are really
info()s or should be dbg()s.
Cheers,
Malte
--
[SGT] Simon G. Tatham: "How to Report Bugs Effectively"
<http://www.chiark.greenend.org.uk/~sgtatham/bugs.html>
[ESR] Eric S. Raymond: "How To Ask Questions The Smart Way"
<http://www.catb.org/~esr/faqs/smart-questions.html>
