On Mon, Jan 31, 2005 at 03:18:03PM -0800, Daniel Quinlan wrote: > > Oh no, I really like the autolearn code in the plugin. Factoring it out > was a fantastic idea. I want to implement a new (slower) plugin to > implement the more optimal autolearning method I proposed and this gives > me the perfect route. >
Sounds like you like the fact that there is a plugin hook there, not that it is a plugin. I agree, lets leave the hook, but the default code shouldn't be in a plugin. It saves nothing, and in the long run makes maintenance and support more difficult. It's just as easy to call the plugin hook, and if nothing ran then run our default (inline) code. Then you don't have to worry about the plugin in the default case, but it makes it very easy to add on your own implementation. Michael
pgpM1FFss9qgd.pgp
Description: PGP signature
