-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Daniel Quinlan writes:
> Michael Parker <[EMAIL PROTECTED]> writes:
>
> > Anyone have any objections to removing the
> > set_persistent_address_list_factory method in SpamAssassin.pm?
> > Besides the obvious, we shouldn't change the API.
>
> I have always hated the silly call ever since I had to add it to
> pop3proxy to get the AWL working.
>
> > I'm more interested in examples of usage in the wild.
>
> pop3proxy and amavisd-new both use it. Speaking as a former developer
> of pop3proxy, I would not have missed it, but it would require some
> special casing if we were to remove it.
I'm sure there's many more clients who call it (even if just as cargo-cult
imitation of how the "spamassassin" script had it ;).
I think removing the function entirely would result in some very nasty
unexpected crashes... especially bad, since we haven't even deprecated
it in a *minor* release yet.
however, +1 on removing all doco -- except for maybe a line noting
that it's a deprecated no-op API -- and setting the code to { }.
- --j.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Exmh CVS
iD8DBQFCBtc8MJF5cimLx9ARAq2cAJ9PTmQI3KDnBNX3Ol5cgXx6YLGI4gCeLsox
J0hbKj6lGgkl9vd1hXpM0u8=
=EZQd
-----END PGP SIGNATURE-----
