http://bugzilla.spamassassin.org/show_bug.cgi?id=4153
------- Additional Comments From [EMAIL PROTECTED] 2005-05-22 03:28 ------- Subject: Re: [review] RFE : Spamc patch for config file -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On (21/05/05 23:53), [EMAIL PROTECTED] didst pronounce: > By default, CONFIG_FILE will be NULL. We need some Makefile.PL magic to allow > you to specify (it's not gonna ask) what the default config file should be: > perl Makefile.PL SPAMC_CONFIG_FILE=/etc/mail/spamassassin/spamc.conf > I just ran a benchmark (using the code you posted here -- thanks :) ). With your patch, and CONFIG_FILE == NULL by default, it's only 1 second quicker over 10000 iterations than with CONFIG_FILE == "@sysconfdir@/spamc.conf" (ie. with my patch). I did make some changes to the version patched with my patch, mainly changed the order of the combine_args call to the same layout as in your patch. Essentially, both patches leave the code in the same state and just change the defined CONFIG_FILE. I didn't have a spamc.conf in @sysconfdir@ for the benchmark, so both benchmarks tested default behaviour. That said, I've no problem with this feature being off by default. Here's the benchmark output : Benchmark: timing 10000 iterations of spamc.me, spamc.parker... spamc.me: 61 wallclock secs ( 0.65 usr 1.71 sys + 36.36 cusr 19.63 csys = 58.35 CPU) @ 4237.29/s (n=10000) spamc.parker: 60 wallclock secs ( 0.60 usr 1.76 sys + 36.26 cusr 19.43 csys = 58.05 CPU) @ 4237.29/s (n=10000) - -- Chat ya later, John. - -- BOFH excuse #1: clock speed -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (GNU/Linux) iD8DBQFCkGCCQBw+ZtKOvTIRAsS9AKCMngf0LH0C7m85PtyCb1KoBTNkNwCdG0S5 PZFTYAvVqjV4G44qiDv+mec= =h7jz -----END PGP SIGNATURE----- ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
