http://bugzilla.spamassassin.org/show_bug.cgi?id=4351
------- Additional Comments From [EMAIL PROTECTED] 2005-05-29 09:15 ------- Subject: Re: spamc broken in trunk on win32 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On (24/05/05 09:46), [EMAIL PROTECTED] didst pronounce: > In order to get the WIN32 build working again so I can turn on my Windows > buildbot, I'm checking in a fix that will cause the Win32 spamc to build with > the configuration file set to "spamc.conf". That will by default load a > spanc.conf file if it exists in the current directory when spamc is executed, > and will work fine when there is no such file. I leave it as an exercise for > someone else to decide where else it should be defined and how to get > spamc/configure.pl to modify spamc.h.win to do it. If anyone thinks it is > important enough, please open up another bug for that. > Ya, this is fine with me aswell. On the other hand, the spamc.conf file was mainly implemented to aid administration on multi-user systems. Windows generally wouldn't have the same type of multi-user setup as *ix etc., so I was thinking simply : #ifndef _WIN32 #include "spamc.h" #else #define CONFIG_FILE NULL #endif would suffice. The config file would still be supported via -F if the user wanted to use it. In other words, is there a need for spamc.conf under Win32? If so, should there be a global default or local default (as with current implementation from this checkin)? If not, defining it to NULL will speed it up _slightly_ instead of having it check for a nonexistant spamc.conf file. I don't really see the need for a spamc.h.win - it just adds complexity to the build where (IMHO) it's not needed. Equally, I don't use Windows or know of anyone running spamd / spamc under Windows, so I don't know if having a default config file is useful for Win32. Even if it is though, #define'ing CONFIG_FILE in spamc.c would be easier than maintaining spamc.h.win. Just my ¤0.02. - -- Chat ya later, John. - -- BOFH excuse #1: clock speed -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (GNU/Linux) iD8DBQFCmeunQBw+ZtKOvTIRAoLcAJ9xtxGYbbZiiwIbv/SZHnAlA9xzUwCfQXQA 2gQ91tP5ULaOSDoWkggj8YA= =bH3W -----END PGP SIGNATURE----- ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
