http://bugzilla.spamassassin.org/show_bug.cgi?id=4520
------- Additional Comments From [EMAIL PROTECTED] 2005-08-10 13:02 ------- Subject: Re: [review] Add plugin hooks for child init/start and child cleanup (after connection has been handled) [EMAIL PROTECTED] wrote: >http://bugzilla.spamassassin.org/show_bug.cgi?id=4520 > > > > > >------- Additional Comments From [EMAIL PROTECTED] 2005-08-10 11:44 ------- >(In reply to comment #8) > > >>It's not called in spamd. >> >> > >Neither was spamd_post_connection_close. This can be changed. > >It seems to me that finish, the destruction of the SpamAssassin object, is the >clearer and more general semantic. It is hard to evaluate this patch without >an >example of what the plugins might do with the callbacks, but it would be better >to use a callback that also makes sense in threading models other than that >currently used in spamd. > > > Adding the finish call to spamd is a separate issue. The two calls are not equivalent. The SA object hangs around until the child exits where as spamd_post_connection_close is called after handling each connection (as defined by max-conn-per-child). I don't have an example that I can show, but I do have a need for something to happen after the child has closed the connection and before it loops to handle the next connection. Here is a good reference for how other servers handle similar hooks: http://perl.apache.org/docs/2.0/user/handlers/http.html#HTTP_Request_Cycle_Phases Michael ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
