On Mon, Nov 07, 2005 at 05:34:07PM -0800, Justin Mason wrote:
> that looks like it's fixed the prob I was talking about -- the "not in
> MANIFEST" errors.

True.  The new options to mkrules seem to have fixed that.  I'll modify
mkrules to auto-find the MANIFEST files as with the --src option and
rulesrc.  (r331672)

> >> The fix is to copy the rule def'n for MPART_ALT_DIFF to your sandbox
> >> file, as T_MPART_ALT_DIFF.  That way your sandbox is entirely
> >> independent of changes to the core ruleset, too.
> >
> >MPART_ALT_DIFF is only referenced in the rulesrc dirs by the "core"
> >files, so that's not quite going to work. :(
> 
> No, it would indeed work -- just cut and paste the line:
> 
>   body T_MPART_ALT_DIFF    eval:multipart_alternative_difference('99', '100')
> 
> it's the same eval call, but a different rule name, and in the
> sandbox file only.

I must be missing something.  No where in my sandbox do I reference
MPART_ALT_DIFF.  The only place I find it, according to grep, is in the
rulesrc/core directory:

$ pwd
/home/felicity/SA/spamassassin-head
$ rm -f rules/*
$ svn -q up rules
$ grep -r MPART_ALT_DIFF rulesrc rules | egrep -v '\.svn|\.txt'
rulesrc/lang/de/30_text_de.cf:lang de describe MPART_ALT_DIFF Nachrichtentext 
im Text- und HTML-Format unterscheiden sich
rulesrc/lang/nl/30_text_nl.cf:lang nl describe MPART_ALT_DIFF                  
HTML en tekst delen zijn verschillend
rulesrc/core/20_body_tests.cf:body MPART_ALT_DIFF       
eval:multipart_alternative_difference('99', '100')
rulesrc/core/20_body_tests.cf:describe MPART_ALT_DIFF   HTML and text parts are 
different
rulesrc/core/20_body_tests.cf:body MPART_ALT_DIFF_COUNT 
eval:multipart_alternative_difference_count('3', '1')
rulesrc/core/20_body_tests.cf:describe MPART_ALT_DIFF_COUNT     HTML and text 
parts are different
rulesrc/core/50_scores.cf:score MPART_ALT_DIFF 0.425 0.137 1.142 0
rulesrc/core/50_scores.cf:score MPART_ALT_DIFF_COUNT 1.649 0 1.607 0.708
$ perl Makefile.PL < /dev/null > /dev/null
$ make > /dev/null
WARNING: MY_SERVERS_FOUND: renamed as T_MY_SERVERS_FOUND due to missing T_ 
prefix
WARNING: BOUNCE_MESSAGE: renamed as T_BOUNCE_MESSAGE due to missing T_ prefix
WARNING: CRBOUNCE_MESSAGE: renamed as T_CRBOUNCE_MESSAGE due to missing T_ 
prefix
WARNING: VBOUNCE_MESSAGE: renamed as T_VBOUNCE_MESSAGE due to missing T_ prefix
config: warning: score set for non-existent rule MPART_ALT_DIFF

ERROR: LINT FAILED, suppressing output: rules/70_sandbox.cf


So there's nothing for me to copy/rename.

-- 
Randomly Generated Tagline:
A block away he wondered if he'd left behind a clue...

Attachment: pgpyxdzf1BP18.pgp
Description: PGP signature

Reply via email to