http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4691
------- Additional Comments From [EMAIL PROTECTED] 2005-11-20 23:59 ------- The testing of the method should be done outside $evalstr2. The method won't change across different messages, so there's no need to put the either the test or the code for the unused methods inside the function defined by $evalstr2. With a large number of "fast_body" rules, SpamAssassin will be spending time repeatedly reconstructing the same string to be searched against. I thought the reason that body and rawbody were split into arrays was to protect against worst-case behavior of test regexes. By pasting those lines back together, this patch appears to forgo that protection. In my opinion, this patch adds way to many knobs to tweak. I don't find the less than 20% performance improvement that compelling, especially given it hands spammers an easy way to prevent SpamAssassin from firing rules on their messages. ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
