Justin Mason wrote:
I'm not sure I see the need for multiple directories lying around. I
suppose it can be useful, I'm assuming that most will only have one
directory. Also, sa-update should be smart enough to remove old
directories of previous versions (optionally?).
The use-case that this helps with, is:
- user of 3.1.1 runs "sa-update"
- sa-update downloads replacement ruleset into /var/lib/spamassassin
- SpamAssassin.pm ignores /usr/share/spamassassin in favour of
/var/lib/spamassassin
- user later upgrades to 3.1.2
- SpamAssassin.pm still ignores /usr/share/spamassassin in favour of
/var/lib/spamassassin, hence attempts to use the now-obsolete
/var/lib/spamassassin ruleset (at least until sa-update is run again).
If we version the /var/lib/spamassassin directory, then we would have
this timeline:
- user of 3.1.1 runs "sa-update"
- sa-update downloads replacement ruleset into /var/lib/spamassassin/3.1.1
- SpamAssassin.pm ignores /usr/share/spamassassin in favour of
/var/lib/spamassassin/3.1.1
- user later upgrades to 3.1.2
- SpamAssassin.pm finds no /var/lib/spamassassin/3.1.2 , so uses
/usr/share/spamassassin
- (at least until the user runs sa-update again and creates
/var/lib/spamassassin/3.1.2)
I think this makes a lot of sense and we should go for it. I also think
that we don't need auto-purging to remove other versions of these
directories. There are just too many things that can go wrong, and
these things are not very big on space consumption.
Warren Togami
[EMAIL PROTECTED]
