http://issues.apache.org/SpamAssassin/show_bug.cgi?id=3109
------- Additional Comments From [EMAIL PROTECTED] 2006-03-22 18:49 ------- side note: after applying this patch, throw http://www.rulesemporium.com/rules/70_sare_whitelist.cf in your local config, your cpu will thank you. if anyone has any additions to 70_sare_whitelist.cf, please contribute via the user list. http://lists.maddoc.net/mailman/listinfo/sare-users thanks. ------- Additional Comments From [EMAIL PROTECTED] 2006-03-22 19:20 ------- sorry to be a downer, but I'm -1 on applying this patch in its current state. I think it's a decent first go, thanks Dallas, but I'd like to see us come up with more of a design before applying code then having to go in and change it all around, etc. here's a number of thoughts I have about the patch: first, I really don't like the override score idea. I don't think there's a real point in doing it, and it's going to cause confusion by people who add up the rules and see it's nowhere near the rule score sum. second, there has to be something in the x-spam-status header to indicate that SC occured. third, mass-check wrt reuse needs to be modified to take SC into account. we'll also need to let people who do mass-checks know that they really shouldn't use SC since we want to see the hit results for all network tests (the current reuse behavior). fourth, what about autolearn? it's likely autolearn won't happen by default (too few hits, etc,) but it could also potentially learn the wrong way depending on what rules hit. I'd like to get a consensus on what should happen here (IMO, autolearn is skipped for SC). fifth, what about AWL? similar to autolearn, except that the score is going to be completely off. IMO, AWL is skipped during SC. sixth, an easy addition to this patch would be short circuiting on current message score. sometimes you don't care what rules hit, but you want to stop after a certain point. seventh, and this is tricky, do we want to try moving the priorities around automatically when SC is enabled? I was thinking of having code that sets default priorities, similar to default score, that goes through the SC rule listing and bumps the priority so they run first (including meta dependencies) unless the rule has a priority specifically set by config. Then another loop which sets the default to priority 0. eighth, should the SC decision code be in a plugin? ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
