http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4777


[EMAIL PROTECTED] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #3581 is|0                           |1
           obsolete|                            |




------- Additional Comments From [EMAIL PROTECTED]  2006-07-14 10:31 -------
Created an attachment (id=3582)
 --> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3582&action=view)
updatedx2 patch

ok, not as bad as I thought!

the failing test was actually a leftover from another patch, so wasn't ever
going to pass on current trunk; the *real* tests all pass.  it was late and I
was tired.

minor typos, though, so here's an updated patch.

benchmarking: looks great!  Using dprof, a mass-check of 222 mixed mails gives
this right at the top of the list, before:

Exclusive Times
%Time ExclSec CumulS #Calls sec/call Csec/c  Name
 2.74   0.580  2.199   1115   0.0005 0.0020  
                        Mail::SpamAssassin::PerMsgStatus::
                        run_eval_tests
 2.16   0.458  0.000    412   0.0011 0.0000  
                        utf8::SWASHNEW
 1.97   0.418  0.473   1197   0.0003 0.0004  
                        Mail::SpamAssassin::Message::Metad
                        ata::parse_received_line


after, 'run_eval_tests' is gone from the top 10; in fact, the first call to any

eval-test-related code is at line 157:

 0.38   0.074  0.088    223   0.0003 0.0004  
                        Mail::SpamAssassin::PerMsgStatus::
                        _check_attachments
 0.38   0.073  0.073   1341   0.0001 0.0001  
                        Mail::SpamAssassin::Conf::Parser::
                        is_regexp_valid
 0.36   0.069  0.764    223   0.0003 0.0034  
                        Mail::SpamAssassin::PerMsgStatus::
                        _eval_tests_type9_pri0_set0             <HERE
 0.36   0.069  0.069    223   0.0003 0.0003  
                        Mail::SpamAssassin::PerMsgStatus::
                        __FRAUD_QXX_body_test
 0.36   0.069  0.069    223   0.0003 0.0003  
                        Mail::SpamAssassin::PerMsgStatus::
                        T_MY_SERVERS_FOUND_body_test


that's way out of the hot-spot area; fantastic.  I'll check that in.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to