http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4941
------- Additional Comments From [EMAIL PROTECTED] 2006-07-22 18:17 ------- (In reply to comment #17) > wow! > +1 ;) :) > there's one issue -- namely that if something stops the files being extracted > in > the second taint_safe_archive_extract() call (such as an out-of-space > condition), those files will be left behind in an incomplete state in > $UPDDir. > I'd like to see those rolled back too, for safety. Fair enough. I'll put up a new version in a minute which covers this and a few other related things. I'm also swapping around "$dir/$file" with File::Spec->catfile($dir, $file) since we really ought to do that more often. ;) > Also, IMO, it should simply copy the files from the tmpdir, instead of > re-extracting them from the tarball again -- which is inefficient. > cross_fs_rename() would be useful to keep for that job. I could go either way I guess. It seems to be easier, though requires more work and disk space, to just unarchive again than to go through the process of moving files from the temp dir. I liked getting rid of File::Copy as a requirement though. ;) BTW: why cross_fs_rename() instead of File::Copy::move() ? > But both of those are icing on the cake, and best considered a separate > issue, > I think... good patch ;) :) Thanks! Sorry for coming up from behind and redoing it on you. This is one of those bugs that have been floating around in my head for a while, and I just needed to sit down and focus on getting a patch out. ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
