http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5105
Summary: M::SA::Client doesn't always catch failed connection to
spamd
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P5
Component: Libraries
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
CC: [email protected]
Sometimes M::SA::Client fails to make a connection to spamd but still continues
on thinking that it has a connection and ends up spewing uninit'd warnings on
STDERR when it later tries to parse the response line. It appears to be a bug
with IO::Socket::INET, but we can easily avoid it.
IO::Socket::INET->new() and thus _create_connection() returns defined, even
though it didn't really get a connection.
One of the methods then sends something on the handle, without any reported
error.
The method then reads from the handle... $line ends up being undef.
$line is then passed to _parse_response_line() which causes a bunch of warnings.
Checking to make sure $line is defined, which it always should be, takes care of
the problem.
Patch to follow.
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
