http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5179
------- Additional Comments From [EMAIL PROTECTED] 2006-11-14 14:19 ------- Justin said in comment 19: "whatever we do here, we should add a test case to the Spamassassin test suite for it." After finding that dkim.org has some test messages, I found that we already have test cases to use them in trunk in t/dkim.t Those tests are all disabled with a comment that it is because we do not enable the DKIM plugin by default. Unless we set up a general mechanism for optional testing of plugins, I think we should just enable the test. It already is conditional on Mail::DKIM and its dependencies being installed, as well as requiring network tests enabled, and I think that is good enough criteria for using it in make test even if the plugin is not enabled for the SpamAssassin installation. However, there is a comment in the tests about a TODO that we should not be dependent on a third party DNS server for our tests. These check the signatures using a record in a subdomain of dkim.org. As if to highlight the potential problem, the tests worked for me yesterday then stopped working this morning because the DNS server that is listed as handling that subdomain has disappeared from DNS. Perhaps that is temporary, but if our tests are going to fail when a system has problems, it should our own systems that are doing the failing. So I don't want to add tests for this fix and enable t/dkim.t until we have added a test DKIM public key to our own test domain DNS records. ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
